revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-15 18:10:53 +01:00
Code Issues Releases Wiki Activity

Explicitly quote "From" name part when submitting mail to the Mailgun API

Browse source 
Summary:
We are submitting `epriestley (Evan Priestley) <noreply@meta.phacility.com>`, but should be submitting `"epriestley (Evan Priestley)" <noreply@meta.phacility.com>`.

Add the missing quotes.

Test Plan: Locally, this makes the API calls work against the Mailgun sandbox domain.

Reviewers: chad, amckinley

Reviewed By: chad, amckinley

Differential Revision: https://secure.phabricator.com/D17831
This commit is contained in:
epriestley 2017-05-04 17:00:02 -07:00
parent 53bc57ecef
commit 733ae2a2e9
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php
View file

@ -86,7 +86,7 @@ final class PhabricatorMailImplementationMailgunAdapter
$from = idx($this->params, 'from'); $from = idx($this->params, 'from');
if (idx($this->params, 'from-name')) { if (idx($this->params, 'from-name')) {
$params['from'] = "{$this->params['from-name']} <{$from}>"; $params['from'] = "\"{$this->params['from-name']}\" <{$from}>";
} else { } else {
$params['from'] = $from; $params['from'] = $from;
} }