revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Differential Action List on Mobile

Browse source 
Summary: Make the actions appear in crumbs on mobile

Test Plan: Test action list on a mobile diff layout

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T4730

Differential Revision: https://secure.phabricator.com/D8691
This commit is contained in:
Chad Little 2014-04-03 12:01:04 -07:00
parent c9311a9eae
commit 7446402f92
2 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/differential/controller/DifferentialRevisionViewController.php
View file

@ -420,6 +420,7 @@ final class DifferentialRevisionViewController extends DifferentialController {
$crumbs = $this->buildApplicationCrumbs(); $crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb($object_id, '/'.$object_id); $crumbs->addTextCrumb($object_id, '/'.$object_id);
$crumbs->setActionList($revision_detail->getActionList());
$prefs = $user->loadPreferences(); $prefs = $user->loadPreferences();

11
src/applications/differential/view/DifferentialRevisionDetailView.php
View file

@ -7,6 +7,7 @@ final class DifferentialRevisionDetailView extends AphrontView {
private $customFields; private $customFields;
private $diff; private $diff;
private $uri; private $uri;
private $actionList;
public function setURI($uri) { public function setURI($uri) {
$this->uri = $uri; $this->uri = $uri;
@ -37,6 +38,15 @@ final class DifferentialRevisionDetailView extends AphrontView {
return $this->actions; return $this->actions;
} }
public function setActionList(PhabricatorActionListView $list) {
$this->actionList = $list;
return $this;
}
public function getActionList() {
return $this->actionList;
}
public function setCustomFields(PhabricatorCustomFieldList $list) { public function setCustomFields(PhabricatorCustomFieldList $list) {
$this->customFields = $list; $this->customFields = $list;
return $this; return $this;
@ -95,6 +105,7 @@ final class DifferentialRevisionDetailView extends AphrontView {
$properties->setHasKeyboardShortcuts(true); $properties->setHasKeyboardShortcuts(true);
$properties->setActionList($actions); $properties->setActionList($actions);
$this->setActionList($actions);
$field_list = $this->customFields; $field_list = $this->customFields;
if ($field_list) { if ($field_list) {