revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-23 03:59:25 +01:00
Code Issues Releases Wiki Activity

Fix extra divs in PHUIBoxView

Browse source 
Summary: This moves the outer classes to the outmost div

Test Plan: Reviewed a few PHUIBox pages

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D6902
This commit is contained in:
Chad Little 2013-09-06 10:42:44 -07:00
parent 03783c4f63
commit 78cbfc3a02
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/view/phui/PHUIBoxView.php
View file

@ -27,10 +27,7 @@ final class PHUIBoxView extends AphrontTagView {
return $this; return $this;
} }
public function getTagContent() { protected function getTagAttributes() {
require_celerity_resource('phui-box-css');
$outer_classes = array(); $outer_classes = array();
$outer_classes[] = 'phui-box'; $outer_classes[] = 'phui-box';
if ($this->shadow) { if ($this->shadow) {
@ -43,24 +40,27 @@ final class PHUIBoxView extends AphrontTagView {
$outer_classes[] = $margin; $outer_classes[] = $margin;
} }
return array('class' => $outer_classes);
}
public function getTagName() {
return 'div';
}
public function getTagContent() {
require_celerity_resource('phui-box-css');
$inner_classes = array(); $inner_classes = array();
$inner_classes[] = 'phui-box-inner'; $inner_classes[] = 'phui-box-inner';
foreach ($this->padding as $padding) { foreach ($this->padding as $padding) {
$inner_classes[] = $padding; $inner_classes[] = $padding;
} }
$inner = phutil_tag( return phutil_tag(
'div', 'div',
array( array(
'class' => implode(' ', $inner_classes) 'class' => implode(' ', $inner_classes)
), ),
$this->renderChildren()); $this->renderChildren());
return phutil_tag(
'div',
array(
'class' => implode(' ', $outer_classes)
),
$inner);
} }
} }