revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
Code Issues Releases Wiki Activity

Explain the relationship between "Runnable" and "Restartable" more clearly in Build Plans

Browse source 
Summary: See PHI1153. The "Runnable" and "Restartable" behaviors interact (to click "restart", you must be able to run the build AND it must be restartable). Make this more clear.

Test Plan: {F6301739}

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Differential Revision: https://secure.phabricator.com/D20307
This commit is contained in:
epriestley 2019-03-22 06:41:00 -07:00
parent c3563ca156
commit 79e36dc7fa
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/applications/harbormaster/plan/HarbormasterBuildPlanBehavior.php
View file

@ -350,15 +350,19 @@ final class HarbormasterBuildPlanBehavior
->setKey(self::BEHAVIOR_RESTARTABLE) ->setKey(self::BEHAVIOR_RESTARTABLE)
->setEditInstructions( ->setEditInstructions(
pht( pht(
'Usually, builds may be restarted. This may be useful if you '. 'Usually, builds may be restarted by users who have permission '.
'suspect a build has failed for environmental or circumstantial '. 'to edit the related build plan. (You can change who is allowed '.
'reasons unrelated to the actual code, and want to give it '. 'to restart a build by adjusting the "Runnable" behavior.)'.
'another chance at glory.'. "\n\n".
'Restarting a build may be useful if you suspect it has failed '.
'for environmental or circumstantial reasons unrelated to the '.
'actual code, and want to give it another chance at glory.'.
"\n\n". "\n\n".
'If you want to prevent a build from being restarted, you can '. 'If you want to prevent a build from being restarted, you can '.
'change the behavior here. This may be useful to prevent '. 'change when it may be restarted by adjusting this behavior. '.
'accidents where a build with a dangerous side effect (like '. 'This may be useful to prevent accidents where a build with a '.
'deployment) is restarted improperly.')) 'dangerous side effect (like deployment) is restarted '.
'improperly.'))
->setName(pht('Restartable')) ->setName(pht('Restartable'))
->setOptions($restart_options), ->setOptions($restart_options),
id(new self()) id(new self())