revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-08 10:24:48 +01:00
Code Issues Releases Wiki Activity

Remove unused appIcon from PHUIListItemView

Browse source 
Summary: This is unused and there's no way to even set it. Pretty sure it died a while ago when we switched app icons to FontAwesome.

Test Plan: Grepped for `appIcon`, found no related hits. Browsed some pages.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15074
This commit is contained in:
epriestley 2016-01-21 10:05:48 -08:00
parent 88e2929411
commit 7d1809f935
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/view/phui/PHUIListItemView.php
View file

@ -19,7 +19,6 @@ final class PHUIListItemView extends AphrontTagView {
private $isExternal; private $isExternal;
private $key; private $key;
private $icon; private $icon;
private $appIcon;
private $selected; private $selected;
private $disabled; private $disabled;
private $renderNameAsTooltip; private $renderNameAsTooltip;
@ -179,7 +178,7 @@ final class PHUIListItemView extends AphrontTagView {
$classes[] = 'phui-list-item-view'; $classes[] = 'phui-list-item-view';
$classes[] = 'phui-list-item-'.$this->type; $classes[] = 'phui-list-item-'.$this->type;
if ($this->icon || $this->appIcon) { if ($this->icon) {
$classes[] = 'phui-list-item-has-icon'; $classes[] = 'phui-list-item-has-icon';
} }
@ -279,12 +278,6 @@ final class PHUIListItemView extends AphrontTagView {
->setImage($this->profileImage); ->setImage($this->profileImage);
} }
if ($this->appIcon) {
$icon = id(new PHUIIconView())
->addClass('phui-list-item-icon')
->setIconFont($this->appIcon);
}
$classes = array(); $classes = array();
if ($this->href) { if ($this->href) {
$classes[] = 'phui-list-item-href'; $classes[] = 'phui-list-item-href';