revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Transactions - fix doorkeeper feed story error

Browse source 
Summary: missing a setHandles on this codepath I think...? Fixes T6300.

Test Plan: not actually tested - I just think this is the fix since the other renderX methods all do this setHandles thing and I can't figure out how handles get set otherwise...

Reviewers: epriestley, avivey

Reviewed By: epriestley, avivey

Subscribers: avivey, Korvin, epriestley

Maniphest Tasks: T6300

Differential Revision: https://secure.phabricator.com/D10699
This commit is contained in:
Bob Trahan 2014-10-13 16:45:58 -07:00
parent 29fbe8ba7f
commit 7d9eb8baaf
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
View file

@ -110,7 +110,9 @@ class PhabricatorApplicationTransactionFeedStory
$xactions = array(); $xactions = array();
$xaction_phids = $this->getValue('transactionPHIDs'); $xaction_phids = $this->getValue('transactionPHIDs');
foreach ($xaction_phids as $xaction_phid) { foreach ($xaction_phids as $xaction_phid) {
$xactions[] = $this->getObject($xaction_phid); $xaction = $this->getObject($xaction_phid);
$xaction->setHandles($this->getHandles());
$xactions[] = $xaction;
} }
$primary = $this->getPrimaryTransaction(); $primary = $this->getPrimaryTransaction();