revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-19 13:22:42 +01:00
Code Issues Releases Wiki Activity

Add missing execution on archived task query

Browse source 
Summary: Fixes T8599. I'm not sure how to reproduce the original issue, but I'm fairly confident that the issue is that the issue is that `execute()` is not called on the query object.

Test Plan: Created a Harbormaster build plan with a single "Lease Host" step. Ran `./bin/harbormaster build --plan 1 D1` from the command line and hit the exception as described in T8599. Applied patch and hit a different exception (which I think is just because I don't know how to use #drydock and #harbormaster).

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: hach-que, epriestley, Korvin

Maniphest Tasks: T8599

Differential Revision: https://secure.phabricator.com/D13335
This commit is contained in:
Joshua Spence 2015-06-18 22:40:04 +10:00
parent dad29171ff
commit 7f6508af5a
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/infrastructure/daemon/workers/PhabricatorWorker.php
View file

@ -199,7 +199,8 @@ abstract class PhabricatorWorker extends Phobject {
} }
$tasks = id(new PhabricatorWorkerArchiveTaskQuery()) $tasks = id(new PhabricatorWorkerArchiveTaskQuery())
->withIDs($task_ids); ->withIDs($task_ids)
->execute();
foreach ($tasks as $task) { foreach ($tasks as $task) {
if ($task->getResult() != PhabricatorWorkerArchiveTask::RESULT_SUCCESS) { if ($task->getResult() != PhabricatorWorkerArchiveTask::RESULT_SUCCESS) {