revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

Add some style to label in Favorites Menu

Browse source 
Summary: Ref T12174. Always sets the correct type when converting to ActionList, adds a type to Divider.

Test Plan:
Add a Label, 2 applications to the personal favorites menu, see nice styles.

{F2554901}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12174

Differential Revision: https://secure.phabricator.com/D17285
This commit is contained in:
Chad Little 2017-01-31 19:47:57 -08:00
parent f4dbe6330a
commit 7fc8e19786
2 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php
View file

@ -61,14 +61,10 @@ final class PhabricatorFavoritesMainMenuBarExtension
$view = id(new PhabricatorActionListView()) $view = id(new PhabricatorActionListView())
->setViewer($viewer); ->setViewer($viewer);
foreach ($item_views as $item) { foreach ($item_views as $item) {
$type = null;
if (!strlen($item->getName())) {
$type = PhabricatorActionView::TYPE_DIVIDER;
}
$action = id(new PhabricatorActionView()) $action = id(new PhabricatorActionView())
->setName($item->getName()) ->setName($item->getName())
->setHref($item->getHref()) ->setHref($item->getHref())
->setType($type); ->setType($item->getType());
$view->addAction($action); $view->addAction($action);
} }

1
src/applications/search/menuitem/PhabricatorDividerProfileMenuItem.php
View file

@ -38,6 +38,7 @@ final class PhabricatorDividerProfileMenuItem
PhabricatorProfileMenuItemConfiguration $config) { PhabricatorProfileMenuItemConfiguration $config) {
$item = $this->newItem() $item = $this->newItem()
->setType(PHUIListItemView::TYPE_DIVIDER)
->addClass('phui-divider'); ->addClass('phui-divider');
return array( return array(