Fix public/private profile edit note

Summary: Fixes T8976. Checks state of note before applying to box.

Test Plan: Set policy to login, edit profile.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8976

Differential Revision: https://secure.phabricator.com/D13739

src/applications/people/controller/PhabricatorPeopleProfileEditController.php

@@ -84,10 +84,13 @@ final class PhabricatorPeopleProfileEditController
 
     $form_box = id(new PHUIObjectBoxView())
       ->setHeaderText(pht('Edit Profile'))
-      ->setInfoView($note)
       ->setValidationException($validation_exception)
       ->setForm($form);
 
+    if ($note) {
+      $form_box->setInfoView($note);
+    }
+
     $nav = $this->buildIconNavView($user);
     $nav->selectFilter('/');
     $nav->appendChild($form_box);