Fix AphrontTagView visibility

Summary: Ref T6822.

Test Plan: `grep`

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11368

src/applications/countdown/view/PhabricatorCountdownView.php

@@ -17,7 +17,7 @@ final class PhabricatorCountdownView extends AphrontTagView {
   }
 
 
-  public function getTagContent() {
+  protected function getTagContent() {
     $countdown = $this->countdown;
 
     require_celerity_resource('phabricator-countdown-css');

src/applications/diviner/view/DivinerBookItemView.php

@@ -27,18 +27,18 @@ final class DivinerBookItemView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'a';
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     return array(
       'class' => 'diviner-book-item',
       'href' => $this->href,
     );
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     require_celerity_resource('diviner-shared-css');
 
     $title = phutil_tag(

src/applications/diviner/view/DivinerParameterTableView.php

@@ -15,17 +15,17 @@ final class DivinerParameterTableView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'div';
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     return array(
       'class' => 'diviner-table-view',
     );
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     require_celerity_resource('diviner-shared-css');
 
     $rows = array();

src/applications/diviner/view/DivinerReturnTableView.php

@@ -15,17 +15,17 @@ final class DivinerReturnTableView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'div';
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     return array(
       'class' => 'diviner-table-view',
     );
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     require_celerity_resource('diviner-shared-css');
 
     $return = $this->return;

src/applications/diviner/view/DivinerSectionView.php

@@ -15,17 +15,17 @@ final class DivinerSectionView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'div';
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     return array(
       'class' => 'diviner-document-section',
     );
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     require_celerity_resource('diviner-shared-css');
 
     $header = id(new PHUIHeaderView())

src/view/form/PHUIPagedFormView.php

@@ -220,7 +220,7 @@ final class PHUIPagedFormView extends AphrontTagView {
     return $this->cancelURI;
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     $form = id(new AphrontFormView())
       ->setUser($this->getUser());
 

src/view/phui/PHUIBoxView.php

@@ -37,11 +37,11 @@ final class PHUIBoxView extends AphrontTagView {
     return array('class' => $outer_classes);
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'div';
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     return $this->renderChildren();
   }
 }

src/view/phui/PHUIButtonBarView.php

@@ -13,11 +13,11 @@ final class PHUIButtonBarView extends AphrontTagView {
     return array('class' => 'phui-button-bar');
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'div';
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     require_celerity_resource('phui-button-css');
 
     $i = 1;

src/view/phui/PHUIButtonView.php

@@ -82,7 +82,7 @@ final class PHUIButtonView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return $this->tag;
   }
 

src/view/phui/PHUIDocumentView.php

@@ -57,7 +57,7 @@ final class PHUIDocumentView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     $classes = array();
 
     if ($this->offset) {
@@ -69,7 +69,7 @@ final class PHUIDocumentView extends AphrontTagView {
     );
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     require_celerity_resource('phui-document-view-css');
     if ($this->fontKit) {
       require_celerity_resource('phui-fontkit-css');

src/view/phui/PHUIIconView.php

@@ -56,7 +56,7 @@ final class PHUIIconView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     $tag = 'span';
     if ($this->href) {
       $tag = 'a';
@@ -64,7 +64,7 @@ final class PHUIIconView extends AphrontTagView {
     return $tag;
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     require_celerity_resource('phui-icon-view-css');
 
     $style = null;

src/view/phui/PHUIImageMaskView.php

@@ -41,11 +41,11 @@ final class PHUIImageMaskView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'div';
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     require_celerity_resource('phui-image-mask-css');
 
     $classes = array();
@@ -62,7 +62,7 @@ final class PHUIImageMaskView extends AphrontTagView {
 
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
 
     /* Center it in the middle of the selected area */
     $center_x = round($this->centerX + ($this->maskW / 2));

src/view/phui/PHUIListView.php

@@ -166,7 +166,7 @@ final class PHUIListView extends AphrontTagView {
     }
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'ul';
   }
 

src/view/phui/PHUIObjectItemView.php

@@ -307,7 +307,7 @@ final class PHUIObjectItemView extends AphrontTagView {
     );
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     $content_classes = array();
     $content_classes[] = 'phui-object-item-content';
 

src/view/phui/PHUIRemarkupPreviewPanel.php

@@ -50,11 +50,11 @@ final class PHUIRemarkupPreviewPanel extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'div';
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     $classes = array();
     $classes[] = 'phui-remarkup-preview';
 

src/view/phui/PHUIStatusListView.php

@@ -13,7 +13,7 @@ final class PHUIStatusListView extends AphrontTagView {
     return false;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'table';
   }
 

src/view/phui/PHUITagView.php

@@ -142,7 +142,7 @@ final class PHUITagView extends AphrontTagView {
     return $attributes + array('class' => $classes);
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     if (!$this->type) {
       throw new Exception(pht('You must call setType() before render()!'));
     }

src/view/phui/PHUITextView.php

@@ -9,11 +9,11 @@ final class PHUITextView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'span';
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     require_celerity_resource('phui-text-css');
     return array();
   }

src/view/phui/PHUIWorkboardView.php

@@ -27,13 +27,13 @@ final class PHUIWorkboardView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     return array(
       'class' => 'phui-workboard-view',
     );
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     require_celerity_resource('phui-workboard-view-css');
 
     $action_list = null;

src/view/phui/PHUIWorkpanelView.php

@@ -55,13 +55,13 @@ final class PHUIWorkpanelView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     return array(
       'class' => 'phui-workpanel-view',
     );
   }
 
-  public function getTagContent() {
+  protected function getTagContent() {
     require_celerity_resource('phui-workpanel-view-css');
 
     $classes = array();

src/view/phui/calendar/PHUICalendarListView.php

@@ -15,11 +15,11 @@ final class PHUICalendarListView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'div';
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     require_celerity_resource('phui-calendar-css');
     require_celerity_resource('phui-calendar-list-css');
     return array('class' => 'phui-calendar-day-list');

src/view/phui/calendar/PHUICalendarWidgetView.php

@@ -15,11 +15,11 @@ final class PHUICalendarWidgetView extends AphrontTagView {
     return $this;
   }
 
-  public function getTagName() {
+  protected function getTagName() {
     return 'div';
   }
 
-  public function getTagAttributes() {
+  protected function getTagAttributes() {
     require_celerity_resource('phui-calendar-list-css');
     return array('class' => 'phui-calendar-list-container');
   }