revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 23:02:42 +01:00
Code Issues Releases Wiki Activity

Fix Main Directory Jump Nav CSS leak

Browse source 
Summary: Good that this isn't a water leak. Else I'd be screwed.

Test Plan:
Visited Main Dir. Looks normal.

Visited Maniphest. Saw ominous shadow on top for saved query. Saw normal paddings for populated list filters.

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5536
This commit is contained in:
Anh Nhan Nguyen 2013-04-02 09:01:09 -07:00 committed by epriestley
parent 37b86b91b9
commit 86312d6986
3 changed files with 46 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

78
src/__celerity_resource_map__.php
View file

@ -2975,7 +2975,7 @@ celerity_register_resource_map(array(
), ),
'phabricator-jump-nav' => 'phabricator-jump-nav' =>
array( array(
'uri' => '/res/b33dd475/rsrc/css/application/directory/phabricator-jump-nav.css', 'uri' => '/res/745c0e89/rsrc/css/application/directory/phabricator-jump-nav.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -3805,7 +3805,7 @@ celerity_register_resource_map(array(
), array( ), array(
'packages' => 'packages' =>
array( array(
'9882678b' => 'c4fbf0c2' =>
array( array(
'name' => 'core.pkg.css', 'name' => 'core.pkg.css',
'symbols' => 'symbols' =>
@ -3847,7 +3847,7 @@ celerity_register_resource_map(array(
34 => 'phabricator-object-item-list-view-css', 34 => 'phabricator-object-item-list-view-css',
35 => 'global-drag-and-drop-css', 35 => 'global-drag-and-drop-css',
), ),
'uri' => '/res/pkg/9882678b/core.pkg.css', 'uri' => '/res/pkg/c4fbf0c2/core.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'def4c982' => 'def4c982' =>
@ -4038,16 +4038,16 @@ celerity_register_resource_map(array(
'reverse' => 'reverse' =>
array( array(
'aphront-attached-file-view-css' => '6b1fccc6', 'aphront-attached-file-view-css' => '6b1fccc6',
'aphront-dialog-view-css' => '9882678b', 'aphront-dialog-view-css' => 'c4fbf0c2',
'aphront-error-view-css' => '9882678b', 'aphront-error-view-css' => 'c4fbf0c2',
'aphront-form-view-css' => '9882678b', 'aphront-form-view-css' => 'c4fbf0c2',
'aphront-list-filter-view-css' => '9882678b', 'aphront-list-filter-view-css' => 'c4fbf0c2',
'aphront-pager-view-css' => '9882678b', 'aphront-pager-view-css' => 'c4fbf0c2',
'aphront-panel-view-css' => '9882678b', 'aphront-panel-view-css' => 'c4fbf0c2',
'aphront-table-view-css' => '9882678b', 'aphront-table-view-css' => 'c4fbf0c2',
'aphront-tokenizer-control-css' => '9882678b', 'aphront-tokenizer-control-css' => 'c4fbf0c2',
'aphront-tooltip-css' => '9882678b', 'aphront-tooltip-css' => 'c4fbf0c2',
'aphront-typeahead-control-css' => '9882678b', 'aphront-typeahead-control-css' => 'c4fbf0c2',
'differential-changeset-view-css' => '8aaacd1b', 'differential-changeset-view-css' => '8aaacd1b',
'differential-core-view-css' => '8aaacd1b', 'differential-core-view-css' => '8aaacd1b',
'differential-inline-comment-editor' => '68d5f4ba', 'differential-inline-comment-editor' => '68d5f4ba',
@ -4061,7 +4061,7 @@ celerity_register_resource_map(array(
'differential-table-of-contents-css' => '8aaacd1b', 'differential-table-of-contents-css' => '8aaacd1b',
'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88',
'global-drag-and-drop-css' => '9882678b', 'global-drag-and-drop-css' => 'c4fbf0c2',
'inline-comment-summary-css' => '8aaacd1b', 'inline-comment-summary-css' => '8aaacd1b',
'javelin-aphlict' => 'def4c982', 'javelin-aphlict' => 'def4c982',
'javelin-behavior' => 'fe22443b', 'javelin-behavior' => 'fe22443b',
@ -4133,48 +4133,48 @@ celerity_register_resource_map(array(
'javelin-util' => 'fe22443b', 'javelin-util' => 'fe22443b',
'javelin-vector' => 'fe22443b', 'javelin-vector' => 'fe22443b',
'javelin-workflow' => 'fe22443b', 'javelin-workflow' => 'fe22443b',
'lightbox-attachment-css' => '9882678b', 'lightbox-attachment-css' => 'c4fbf0c2',
'maniphest-task-summary-css' => '6b1fccc6', 'maniphest-task-summary-css' => '6b1fccc6',
'maniphest-transaction-detail-css' => '6b1fccc6', 'maniphest-transaction-detail-css' => '6b1fccc6',
'phabricator-busy' => 'def4c982', 'phabricator-busy' => 'def4c982',
'phabricator-content-source-view-css' => '8aaacd1b', 'phabricator-content-source-view-css' => '8aaacd1b',
'phabricator-core-buttons-css' => '9882678b', 'phabricator-core-buttons-css' => 'c4fbf0c2',
'phabricator-core-css' => '9882678b', 'phabricator-core-css' => 'c4fbf0c2',
'phabricator-crumbs-view-css' => '9882678b', 'phabricator-crumbs-view-css' => 'c4fbf0c2',
'phabricator-directory-css' => '9882678b', 'phabricator-directory-css' => 'c4fbf0c2',
'phabricator-drag-and-drop-file-upload' => '68d5f4ba', 'phabricator-drag-and-drop-file-upload' => '68d5f4ba',
'phabricator-dropdown-menu' => 'def4c982', 'phabricator-dropdown-menu' => 'def4c982',
'phabricator-file-upload' => 'def4c982', 'phabricator-file-upload' => 'def4c982',
'phabricator-filetree-view-css' => '9882678b', 'phabricator-filetree-view-css' => 'c4fbf0c2',
'phabricator-flag-css' => '9882678b', 'phabricator-flag-css' => 'c4fbf0c2',
'phabricator-form-view-css' => '9882678b', 'phabricator-form-view-css' => 'c4fbf0c2',
'phabricator-header-view-css' => '9882678b', 'phabricator-header-view-css' => 'c4fbf0c2',
'phabricator-jump-nav' => '9882678b', 'phabricator-jump-nav' => 'c4fbf0c2',
'phabricator-keyboard-shortcut' => 'def4c982', 'phabricator-keyboard-shortcut' => 'def4c982',
'phabricator-keyboard-shortcut-manager' => 'def4c982', 'phabricator-keyboard-shortcut-manager' => 'def4c982',
'phabricator-main-menu-view' => '9882678b', 'phabricator-main-menu-view' => 'c4fbf0c2',
'phabricator-menu-item' => 'def4c982', 'phabricator-menu-item' => 'def4c982',
'phabricator-nav-view-css' => '9882678b', 'phabricator-nav-view-css' => 'c4fbf0c2',
'phabricator-notification' => 'def4c982', 'phabricator-notification' => 'def4c982',
'phabricator-notification-css' => '9882678b', 'phabricator-notification-css' => 'c4fbf0c2',
'phabricator-notification-menu-css' => '9882678b', 'phabricator-notification-menu-css' => 'c4fbf0c2',
'phabricator-object-item-list-view-css' => '9882678b', 'phabricator-object-item-list-view-css' => 'c4fbf0c2',
'phabricator-object-selector-css' => '8aaacd1b', 'phabricator-object-selector-css' => '8aaacd1b',
'phabricator-paste-file-upload' => 'def4c982', 'phabricator-paste-file-upload' => 'def4c982',
'phabricator-prefab' => 'def4c982', 'phabricator-prefab' => 'def4c982',
'phabricator-project-tag-css' => '6b1fccc6', 'phabricator-project-tag-css' => '6b1fccc6',
'phabricator-remarkup-css' => '9882678b', 'phabricator-remarkup-css' => 'c4fbf0c2',
'phabricator-shaped-request' => '68d5f4ba', 'phabricator-shaped-request' => '68d5f4ba',
'phabricator-side-menu-view-css' => '9882678b', 'phabricator-side-menu-view-css' => 'c4fbf0c2',
'phabricator-standard-page-view' => '9882678b', 'phabricator-standard-page-view' => 'c4fbf0c2',
'phabricator-textareautils' => 'def4c982', 'phabricator-textareautils' => 'def4c982',
'phabricator-tooltip' => 'def4c982', 'phabricator-tooltip' => 'def4c982',
'phabricator-transaction-view-css' => '9882678b', 'phabricator-transaction-view-css' => 'c4fbf0c2',
'phabricator-zindex-css' => '9882678b', 'phabricator-zindex-css' => 'c4fbf0c2',
'sprite-apps-large-css' => '9882678b', 'sprite-apps-large-css' => 'c4fbf0c2',
'sprite-gradient-css' => '9882678b', 'sprite-gradient-css' => 'c4fbf0c2',
'sprite-icon-css' => '9882678b', 'sprite-icon-css' => 'c4fbf0c2',
'sprite-menu-css' => '9882678b', 'sprite-menu-css' => 'c4fbf0c2',
'syntax-highlighting-css' => '9882678b', 'syntax-highlighting-css' => 'c4fbf0c2',
), ),
)); ));

6
src/applications/directory/controller/PhabricatorDirectoryMainController.php
View file

@ -360,7 +360,11 @@ final class PhabricatorDirectoryMainController
$list_filter->appendChild(phutil_tag('h1', array(), 'Jump Nav')); $list_filter->appendChild(phutil_tag('h1', array(), 'Jump Nav'));
$list_filter->appendChild($form); $list_filter->appendChild($form);
return $list_filter; $container = phutil_tag('div',
array('class' => 'phabricator-jump-nav-container'),
$list_filter);
return $container;
} }
private function renderMiniPanel($title, $body) { private function renderMiniPanel($title, $body) {

4
webroot/rsrc/css/application/directory/phabricator-jump-nav.css
View file

@ -25,11 +25,11 @@
text-align: left; text-align: left;
} }
.aphront-list-filter-view-controls { .phabricator-jump-nav-container .aphront-list-filter-view-controls {
padding: 20px; padding: 20px;
} }
.aphront-list-filter-view-controls h1 { .phabricator-jump-nav-container .aphront-list-filter-view-controls h1 {
color: #555; color: #555;
padding-top: 4px; padding-top: 4px;
margin-bottom: 0.67em; margin-bottom: 0.67em;