revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00
Code Issues Releases Wiki Activity

Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after recent changes

Browse source 
Summary: Ref T13303. I upgraded this to a vector-based sort but forgot to type a "v", which means the sort has different stability under PHP 5.5. See D20582 for a root cause fix.

Test Plan: Locally, on PHP7, not much changes. I expect this to fix the odd selection of title stories in mail and notification stories on `secure`, which is running PHP 5.5.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13303

Differential Revision: https://secure.phabricator.com/D20583
This commit is contained in:
epriestley 2019-06-17 10:36:59 -07:00
parent d3112392d1
commit 874282db75
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
View file

@ -3267,7 +3267,7 @@ abstract class PhabricatorApplicationTransactionEditor
protected function getStrongestAction(
PhabricatorLiskDAO $object,
array $xactions) {
return head(msort($xactions, 'newActionStrengthSortVector'));
return head(msortv($xactions, 'newActionStrengthSortVector'));
}