revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 09:20:58 +01:00
Code Issues Releases Wiki Activity

Make use of "Mnn" in Pholio more consistent

Browse source 
Summary:
  - Drop it from crumb.
  - Add it to pinboard.
  - Drop it from header.
  - Add it to title.

Test Plan: looked at stuff

Reviewers: chad, ljalonen

Reviewed By: ljalonen

CC: aran

Differential Revision: https://secure.phabricator.com/D5068
This commit is contained in:
epriestley 2013-02-22 06:53:35 -08:00
parent b180c3a009
commit 88698bec0b
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/pholio/controller/PholioMockListController.php
View file

@ -43,7 +43,7 @@ final class PholioMockListController extends PholioController {
foreach ($mocks as $mock) { foreach ($mocks as $mock) {
$board->addItem( $board->addItem(
id(new PhabricatorPinboardItemView()) id(new PhabricatorPinboardItemView())
->setHeader($mock->getName()) ->setHeader('M'.$mock->getID().' '.$mock->getName())
->setURI('/M'.$mock->getID()) ->setURI('/M'.$mock->getID())
->setImageURI($mock->getCoverFile()->getThumb220x165URI()) ->setImageURI($mock->getCoverFile()->getThumb220x165URI())
->setImageSize(220, 165)); ->setImageSize(220, 165));

8
src/applications/pholio/controller/PholioMockViewController.php
View file

@ -54,7 +54,7 @@ final class PholioMockViewController extends PholioController {
} }
$engine->process(); $engine->process();
$title = 'M'.$mock->getID().' '.$mock->getName(); $title = $mock->getName();
$header = id(new PhabricatorHeaderView()) $header = id(new PhabricatorHeaderView())
->setHeader($title); ->setHeader($title);
@ -78,8 +78,8 @@ final class PholioMockViewController extends PholioController {
$crumbs = $this->buildApplicationCrumbs($this->buildSideNav()); $crumbs = $this->buildApplicationCrumbs($this->buildSideNav());
$crumbs->addCrumb( $crumbs->addCrumb(
id(new PhabricatorCrumbView()) id(new PhabricatorCrumbView())
->setName($title) ->setName('M'.$mock->getID())
->setHref($this->getApplicationURI().'M'.$this->id)); ->setHref('/M'.$mock->getID()));
$content = array( $content = array(
$crumbs, $crumbs,
@ -98,7 +98,7 @@ final class PholioMockViewController extends PholioController {
return $this->buildApplicationPage( return $this->buildApplicationPage(
$content, $content,
array( array(
'title' => $title, 'title' => 'M'.$mock->getID().' '.$title,
'device' => true, 'device' => true,
'pageObjects' => array($mock->getPHID()), 'pageObjects' => array($mock->getPHID()),
)); ));