revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Fix a "setExternalURI()" fatal while browsing directories with submodules

Browse source 
Summary:
Ref T13595. See that task for discussion.

D21511 renamed the iteration variable here (previously "$path") but did not rename this use of it.

Test Plan:
  - In Diffusion, browsed a directory with a submodule.
    - Before: "setExternalURI()" fatal in conduit call.
    - After: directory listing including submodule.

Maniphest Tasks: T13595

Differential Revision: https://secure.phabricator.com/D21520
This commit is contained in:
epriestley 2021-01-26 08:39:59 -08:00
parent bafe8d1bbd
commit 888604c9dd
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php
View file

@ -240,7 +240,7 @@ final class DiffusionBrowseQueryConduitAPIMethod
$full_path = $submodule_path->getFullPath(); $full_path = $submodule_path->getFullPath();
$key = 'submodule.'.$full_path.'.url'; $key = 'submodule.'.$full_path.'.url';
if (isset($dict[$key])) { if (isset($dict[$key])) {
$path->setExternalURI($dict[$key]); $submodule_path->setExternalURI($dict[$key]);
} }
} }
} }