revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 03:50:54 +01:00
Code Issues Releases Wiki Activity

Simplify "Blame Revision" field in Differential

Browse source 
Summary: Ref T11114. This is still mostly in use, but toss a few commit message parsing things.

Test Plan: Viewed/edited/upated blame rev from CLI/web UI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17089
This commit is contained in:
epriestley 2016-12-16 10:06:12 -08:00
parent 60f41b87e9
commit 895cdaca5d
1 changed files with 4 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/applications/differential/customfield/DifferentialBlameRevisionField.php
View file

@ -32,6 +32,10 @@ final class DifferentialBlameRevisionField
} }
public function renderPropertyViewValue(array $handles) { public function renderPropertyViewValue(array $handles) {
if (!strlen($this->getValue())) {
return null;
}
return $this->getValue(); return $this->getValue();
} }
@ -91,25 +95,6 @@ final class DifferentialBlameRevisionField
return true; return true;
} }
public function shouldAllowEditInCommitMessage() {
return true;
}
public function shouldOverwriteWhenCommitMessageIsEdited() {
return true;
}
public function getCommitMessageLabels() {
return array(
'Blame Revision',
'Blame Rev',
);
}
public function renderCommitMessageValue(array $handles) {
return $this->getValue();
}
public function shouldAppearInConduitDictionary() { public function shouldAppearInConduitDictionary() {
return true; return true;
} }