revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 06:50:55 +01:00
Code Issues Releases Wiki Activity

Move build status to the bottom of the property list

Browse source 
Summary: This moves the status property of the build to the bottom of the property list so that it matches the build targets.

Test Plan: Viewed a build, saw the status in the right position.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10096
This commit is contained in:
James Rhodes 2014-08-01 08:10:09 +10:00
parent 7e0edd8ef0
commit 8b5192ed71
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
View file

@ -331,10 +331,6 @@ final class HarbormasterBuildViewController
->setActionList($actions); ->setActionList($actions);
$box->addPropertyList($properties); $box->addPropertyList($properties);
$properties->addProperty(
pht('Status'),
$this->getStatus($build));
$handles = id(new PhabricatorHandleQuery()) $handles = id(new PhabricatorHandleQuery())
->setViewer($viewer) ->setViewer($viewer)
->withPHIDs(array( ->withPHIDs(array(
@ -350,6 +346,10 @@ final class HarbormasterBuildViewController
pht('Build Plan'), pht('Build Plan'),
$handles[$build->getBuildPlanPHID()]->renderLink()); $handles[$build->getBuildPlanPHID()]->renderLink());
$properties->addProperty(
pht('Status'),
$this->getStatus($build));
} }
private function getStatus(HarbormasterBuild $build) { private function getStatus(HarbormasterBuild $build) {