Make header alignment/layout less horrible.

Summary: <table />s repruhsent

Test Plan:

Reviewers:

CC:

src/applications/differential/data/commitmessage/DifferentialCommitMessageData.php

@@ -93,7 +93,7 @@ class DifferentialCommitMessageData {
     }
 
     $handles = id(new PhabricatorObjectHandleData($phids))
-      ->loadHandles($handles);
+      ->loadHandles();
 
     if ($this->mode == self::MODE_AMEND) {
       if ($reviewer) {

src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php

@@ -388,8 +388,6 @@ class DifferentialCommitMessage {
           $data = (int)preg_replace('/[^\d]/', '', $data);
           break;
         case 'CC':
-          $data = preg_replace('/\s+/', ' ', $data);
-          break;
         case 'Reviewers':
         case 'Reviewed By':
           $data = array_filter(preg_split('/[\s,]+/', $data));

src/view/page/standard/PhabricatorStandardPageView.php

@@ -132,20 +132,23 @@ class PhabricatorStandardPageView extends AphrontPageView {
 
     $tabs = array();
     foreach ($this->tabs as $name => $tab) {
-      $tabs[] = phutil_render_tag(
+      $tab_markup = phutil_render_tag(
         'a',
         array(
           'href'  => idx($tab, 'href'),
+        ),
+        phutil_escape_html(idx($tab, 'name')));
+      $tab_markup = phutil_render_tag(
+        'td',
+        array(
           'class' => ($name == $this->selectedTab)
             ? 'phabricator-selected-tab'
             : null,
         ),
-        phutil_escape_html(idx($tab, 'name')));
+        $tab_markup);
+      $tabs[] = $tab_markup;
     }
     $tabs = implode('', $tabs);
-    if ($tabs) {
-      $tabs = '<span class="phabricator-head-tabs">'.$tabs.'</span>';
-    }
 
     $login_stuff = null;
     $request = $this->getRequest();
@@ -215,7 +218,14 @@ class PhabricatorStandardPageView extends AphrontPageView {
           '<div class="phabricator-login-details">'.
             $login_stuff.
           '</div>'.
-          '<a href="/">Phabricator</a> '.
+          '<table class="phabricator-primary-navigation">'.
+            '<tr>'.
+              '<th class="phabricator-logo">'.
+                '<a href="/">'.
+                  "Phabricat\xE2\x9A\x99r".
+                '</a> '.
+              '</th>'.
+              '<th>'.
                 phutil_render_tag(
                   'a',
                   array(
@@ -223,7 +233,10 @@ class PhabricatorStandardPageView extends AphrontPageView {
                     'class' => 'phabricator-head-appname',
                   ),
                   phutil_escape_html($this->getApplicationName())).
+              '</th>'.
               $tabs.
+            '</tr>'.
+          '</table>'.
         '</div>'.
         $this->bodyContent.
         '<div style="clear: both;"></div>'.

webroot/rsrc/css/application/base/standard-page-view.css

@@ -13,32 +13,45 @@
 }
 
 .phabricator-standard-header {
-  background: #003366;
+  background: #006699;
   color: white;
-  padding: 1em 1em 0.5em 1em;
   overflow: hidden;
   position: relative;
 }
 
+.phabricator-primary-navigation {
+  padding-top: 12px;
+  padding-bottom: 8px;
+  padding-left: 24px;
+}
+
 .phabricator-standard-header a {
   color: white;
 }
 
-.phabricator-standard-header .phabricator-head-tabs {
+.phabricator-primary-navigation th,
-  padding: 0 1em;
+.phabricator-primary-navigation td {
+  vertical-align: bottom;
   font-size: 13px;
-  font-weight: bold;
+  border-bottom: 6px solid transparent;
+  padding-bottom: 4px;
 }
 
-.phabricator-standard-header .phabricator-head-tabs a {
+.phabricator-primary-navigation th.phabricator-logo {
-  border-bottom: 3px solid transparent;
+  font-size: 16px;
-  padding: 0.5em 0.75em;
+  padding-top: 8px;
-  position: relative;
+  padding-left: 24px;
-  bottom: 2px;
+  padding-right: 6px;
 }
 
-.phabricator-standard-header .phabricator-head-tabs a.phabricator-selected-tab {
+.phabricator-primary-navigation td {
-  border-bottom-color: #cccccc;
+  padding-left: 10px;
+  padding-right: 10px;
+}
+
+.phabricator-primary-navigation td.phabricator-selected-tab {
+  border-bottom-color: #ffffff;
+  background: #3377aa;
 }
 
 .phabricator-standard-header .phabricator-head-appname {
@@ -48,6 +61,8 @@
 
 .phabricator-login-details {
   float: right;
+  padding: 6px 24px 0;
+  font-size: 12px;
 }
 
 .phabricator-page-foot {