revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Subversion - set minimum required version to 1.5

Browse source 
Summary: Fixes T7228.

Test Plan: hacked $version to be '1.4' and saw the proper error message

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7228

Differential Revision: https://secure.phabricator.com/D11732
This commit is contained in:
Bob Trahan 2015-02-10 12:07:18 -08:00
parent d66cbff298
commit 91a1f56a4c
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/config/check/PhabricatorBinariesSetupCheck.php
View file

@ -102,11 +102,11 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck {
$version = trim(substr($stdout, strlen('git version '))); $version = trim(substr($stdout, strlen('git version ')));
break; break;
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
$minimum_version = null; $minimum_version = '1.5';
$bad_versions = array( $bad_versions = array(
'1.7.1' => pht('This version of Subversion has a bug where '. '1.7.1' => pht('This version of Subversion has a bug where '.
'"svn diff -c N" does not work for files added '. '"svn diff -c N" does not work for files added '.
'in rN (Subverison issue #2873), fixed in 1.7.2.'),); 'in rN (Subversion issue #2873), fixed in 1.7.2.'),);
list($err, $stdout, $stderr) = exec_manual('svn --version --quiet'); list($err, $stdout, $stderr) = exec_manual('svn --version --quiet');
$version = trim($stdout); $version = trim($stdout);
break; break;
@ -232,7 +232,6 @@ final class PhabricatorBinariesSetupCheck extends PhabricatorSetupCheck {
case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT: case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT:
break; break;
case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
break;
case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL: case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL:
$summary = pht( $summary = pht(
"The '%s' binary is version %s and Phabricator requires version ". "The '%s' binary is version %s and Phabricator requires version ".