revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Fix a view fatal in CommitGraphView when commits are undiscovered

Browse source 
Summary:
Ref T13552. See <https://discourse.phabricator-community.org/t/viewing-repository-history-for-svn-repository-causes-unhandled-exception/4225/>.

This condition is flipped and can fatal by passing a `NULL` value for `$commit` to a typehinted method.

Test Plan: Viewed history page with undiscovered commits.

Maniphest Tasks: T13552

Differential Revision: https://secure.phabricator.com/D21458
This commit is contained in:
epriestley 2020-09-08 12:00:05 -07:00
parent a39c590442
commit 93ef902ffa
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diffusion/view/DiffusionCommitGraphView.php
View file

@ -485,7 +485,7 @@ final class DiffusionCommitGraphView
$buildable = null; $buildable = null;
$commit = $this->getCommit($hash); $commit = $this->getCommit($hash);
if (!$commit) { if ($commit) {
$buildable = $this->getBuildable($commit); $buildable = $this->getBuildable($commit);
} }