revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Make getApplicationTransactionEditor() in PhabricatorApplication return an editor

Browse source 
Summary:
Ref T12685. I provided this incorrect (`return new` rather than `throw`) implementation earlier; it can now be replaced with a proper implementation.

This caused application policy edits to spew this into the daemon log:

```
[2017-05-14 15:35:27] EXCEPTION: (Error) Call to undefined method PhutilMethodNotImplementedException::setActor() at [<phabricator>/src/applications/transactions/worker/PhabricatorApplicationTransactionPublishWorker.php:69]
```

Test Plan:
  - Used `bin/worker execute --id <id>` to execute a previously-failing task.
  - Saw a feed story publish.

Reviewers: chad, amckinley

Reviewed By: chad

Maniphest Tasks: T12685

Differential Revision: https://secure.phabricator.com/D17876
This commit is contained in:
epriestley 2017-05-14 13:35:54 -07:00
parent aa81979922
commit 95925ad58f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/base/PhabricatorApplication.php
View file

@ -642,7 +642,7 @@ abstract class PhabricatorApplication
public function getApplicationTransactionEditor() {
return new PhutilMethodNotImplementedException(pht('Coming Soon!'));
return new PhabricatorApplicationEditor();
}
public function getApplicationTransactionObject() {