revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 06:42:42 +01:00
Code Issues Releases Wiki Activity

Fix call to non-existing newIcons() in PhabricatorIconSet

Browse source 
Summary:
`PhabricatorIconSet::getIcons()` calls `$this->newIcons()` which is undefined.

As all six child classes which extend `PhabricatorIconSet` implement `newIcons()`, declare an abstract function in their parent class.

Test Plan: Carefully read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25647
This commit is contained in:
Andre Klapper 2024-05-16 13:02:58 +02:00
parent a8af0c6e51
commit 98884f758a
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/files/iconset/PhabricatorIconSet.php
View file

@ -3,6 +3,8 @@
abstract class PhabricatorIconSet abstract class PhabricatorIconSet
extends Phobject { extends Phobject {
abstract protected function newIcons();
final public function getIconSetKey() { final public function getIconSetKey() {
return $this->getPhobjectClassConstant('ICONSETKEY'); return $this->getPhobjectClassConstant('ICONSETKEY');
} }