1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 02:32:42 +01:00

Make the "PHP 7" setup warning more explicit about what it means

Summary: See <https://discourse.phabricator-community.org/t/minimum-php-versions-supported-by-latest-stable-phabricator/2314/3>.

Test Plan: o~o

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20027
This commit is contained in:
epriestley 2019-01-23 14:32:00 -08:00
parent 5cfcef7f53
commit 98c4cdc5be

View file

@ -11,16 +11,23 @@ final class PhabricatorPHPPreflightSetupCheck extends PhabricatorSetupCheck {
} }
protected function executeChecks() { protected function executeChecks() {
if (version_compare(phpversion(), 7, '>=') && $version = phpversion();
version_compare(phpversion(), 7.1, '<')) { if (version_compare($version, 7, '>=') &&
version_compare($version, 7.1, '<')) {
$message = pht( $message = pht(
'This version of Phabricator does not support PHP 7.0. You '. 'You are running PHP version %s. Phabricator does not support PHP '.
'are running PHP %s. Upgrade to PHP 7.1 or newer.', 'versions between 7.0 and 7.1.'.
phpversion()); "\n\n".
'PHP removed signal handling features that Phabricator requires in '.
'PHP 7.0, and did not restore them until PHP 7.1.'.
"\n\n".
'Upgrade to PHP 7.1 or newer (recommended) or downgrade to an older '.
'version of PHP 5 (discouraged).',
$version);
$this->newIssue('php.version7') $this->newIssue('php.version7')
->setIsFatal(true) ->setIsFatal(true)
->setName(pht('PHP 7.0 Not Supported')) ->setName(pht('PHP 7.0-7.1 Not Supported'))
->setMessage($message) ->setMessage($message)
->addLink( ->addLink(
'https://phurl.io/u/php7', 'https://phurl.io/u/php7',