1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 01:08:50 +02:00

Use wide links instead of fake cursor in Differential

Summary:
Current approach has several problems:

- if there is no link in the cell then it still shows a link cursor
- if there is a link then it is clickable only on the text

Test Plan:
Display file in Differential, hover over cell with link.
Repeat for Paste.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1701
This commit is contained in:
vrana 2012-02-25 23:21:05 -08:00
parent efa2ab2fef
commit 991fee2118
3 changed files with 5 additions and 8 deletions

View file

@ -267,7 +267,7 @@ celerity_register_resource_map(array(
),
'diffusion-source-css' =>
array(
'uri' => '/res/db4566b6/rsrc/css/application/diffusion/diffusion-source.css',
'uri' => '/res/a8d2834e/rsrc/css/application/diffusion/diffusion-source.css',
'type' => 'css',
'requires' =>
array(

View file

@ -405,7 +405,6 @@ class DiffusionBrowseFileController extends DiffusionController {
$l = phutil_render_tag(
'a',
array(
'class' => 'diffusion-line-link',
'href' => $uri_path.';'.$uri_rev.'$'.$n.$uri_view,
),
$n);

View file

@ -17,7 +17,6 @@
vertical-align: top;
background: #eeeeee;
color: #888888;
cursor: pointer;
border-style: solid;
border-width: 0px 1px;
border-color: #eeeeee #999999 #eeeeee #dddddd;
@ -27,6 +26,10 @@
overflow: hidden;
}
.diffusion-source th a {
display: block;
}
.diffusion-source td {
letter-spacing: 0.0083334px;
vertical-align: top;
@ -37,11 +40,6 @@
overflow: hidden;
}
.diffusion-line-link {
/* Give the user a larger click target. */
display: block;
}
.diffusion-browse-type-form {
float: right;
}