mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-27 16:00:59 +01:00
Use wide links instead of fake cursor in Differential
Summary: Current approach has several problems: - if there is no link in the cell then it still shows a link cursor - if there is a link then it is clickable only on the text Test Plan: Display file in Differential, hover over cell with link. Repeat for Paste. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1701
This commit is contained in:
parent
efa2ab2fef
commit
991fee2118
3 changed files with 5 additions and 8 deletions
|
@ -267,7 +267,7 @@ celerity_register_resource_map(array(
|
||||||
),
|
),
|
||||||
'diffusion-source-css' =>
|
'diffusion-source-css' =>
|
||||||
array(
|
array(
|
||||||
'uri' => '/res/db4566b6/rsrc/css/application/diffusion/diffusion-source.css',
|
'uri' => '/res/a8d2834e/rsrc/css/application/diffusion/diffusion-source.css',
|
||||||
'type' => 'css',
|
'type' => 'css',
|
||||||
'requires' =>
|
'requires' =>
|
||||||
array(
|
array(
|
||||||
|
|
|
@ -405,7 +405,6 @@ class DiffusionBrowseFileController extends DiffusionController {
|
||||||
$l = phutil_render_tag(
|
$l = phutil_render_tag(
|
||||||
'a',
|
'a',
|
||||||
array(
|
array(
|
||||||
'class' => 'diffusion-line-link',
|
|
||||||
'href' => $uri_path.';'.$uri_rev.'$'.$n.$uri_view,
|
'href' => $uri_path.';'.$uri_rev.'$'.$n.$uri_view,
|
||||||
),
|
),
|
||||||
$n);
|
$n);
|
||||||
|
|
|
@ -17,7 +17,6 @@
|
||||||
vertical-align: top;
|
vertical-align: top;
|
||||||
background: #eeeeee;
|
background: #eeeeee;
|
||||||
color: #888888;
|
color: #888888;
|
||||||
cursor: pointer;
|
|
||||||
border-style: solid;
|
border-style: solid;
|
||||||
border-width: 0px 1px;
|
border-width: 0px 1px;
|
||||||
border-color: #eeeeee #999999 #eeeeee #dddddd;
|
border-color: #eeeeee #999999 #eeeeee #dddddd;
|
||||||
|
@ -27,6 +26,10 @@
|
||||||
overflow: hidden;
|
overflow: hidden;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.diffusion-source th a {
|
||||||
|
display: block;
|
||||||
|
}
|
||||||
|
|
||||||
.diffusion-source td {
|
.diffusion-source td {
|
||||||
letter-spacing: 0.0083334px;
|
letter-spacing: 0.0083334px;
|
||||||
vertical-align: top;
|
vertical-align: top;
|
||||||
|
@ -37,11 +40,6 @@
|
||||||
overflow: hidden;
|
overflow: hidden;
|
||||||
}
|
}
|
||||||
|
|
||||||
.diffusion-line-link {
|
|
||||||
/* Give the user a larger click target. */
|
|
||||||
display: block;
|
|
||||||
}
|
|
||||||
|
|
||||||
.diffusion-browse-type-form {
|
.diffusion-browse-type-form {
|
||||||
float: right;
|
float: right;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue