revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Fix an undefined variable

Browse source 
Summary:
The `$timeline` variable is undefined. I was seeing the following error in the logs:

```
EXCEPTION: (RuntimeException) Undefined variable: timeline at [<phutil>/src/error/PhutilErrorHandler.php:210]
   #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/harbormaster/controller/HarbormasterStepEditController.php:205]
   #1 HarbormasterStepEditController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33]
   #2 AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/webroot/index.php:103]
```

Test Plan: Created a build step without a fatal error.

Reviewers: btrahan, hach-que, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D10941
This commit is contained in:
Joshua Spence 2014-12-08 04:11:08 -08:00 committed by epriestley
parent 46b775820a
commit 9e54e6e886
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/harbormaster/controller/HarbormasterStepEditController.php
View file

@ -190,6 +190,7 @@ final class HarbormasterStepEditController extends HarbormasterController {
if ($is_new) { if ($is_new) {
$xaction_view = null; $xaction_view = null;
$timeline = null;
} else { } else {
$timeline = $this->buildTransactionTimeline( $timeline = $this->buildTransactionTimeline(
$step, $step,