revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00
Code Issues Releases Wiki Activity

Remove unusual unicode marks in Differential action dropdown

Browse source 
Summary:
See <https://twitter.com/HayleyCAnderson/status/988873585363009536>.

Currently, the action dropdown in Differential shows a heavy "X" after "Request Changes" and a heavy checkmark after "Accept Revision".

Although I'm not convinced that the messaging around "Request Changes" is too strong, I do think these marks are out of place in modern Differential. They came from a simpler time when this dropdown had fewer actions, but feel a little weird and inconsistent to me in the modern UI.

Let's try getting rid of them and see how it goes?

Test Plan:
  - Viewed these actions in the dropdown, no longer saw the mark icons.
  - Grepped for these unicode sequences without getting any other hits.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19405
This commit is contained in:
epriestley 2018-04-25 06:17:17 -07:00
parent b4796d2837
commit 9f8e0ad473
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
View file

@ -7,7 +7,7 @@ final class DifferentialRevisionAcceptTransaction
const ACTIONKEY = 'accept';
protected function getRevisionActionLabel() {
return pht("Accept Revision \xE2\x9C\x94");
return pht('Accept Revision');
}
protected function getRevisionActionDescription(

2
src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php
View file

@ -7,7 +7,7 @@ final class DifferentialRevisionRejectTransaction
const ACTIONKEY = 'reject';
protected function getRevisionActionLabel() {
return pht("Request Changes \xE2\x9C\x98");
return pht('Request Changes');
}
protected function getRevisionActionDescription(