mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 23:02:42 +01:00
Change PHP 7 setup warning to complain about 7.0 only, not 7.1+
Summary: Ref T9640. On 7.0 we had signal handling issues so we can never support it, but async signals should resolve them on 7.1 or newer. Test Plan: On PHP 7.1, got through the setup warning. Reviewers: chad Reviewed By: chad Maniphest Tasks: T9640 Differential Revision: https://secure.phabricator.com/D17197
This commit is contained in:
parent
4a34f26a44
commit
a2cd3d9a89
1 changed files with 5 additions and 4 deletions
|
@ -11,15 +11,16 @@ final class PhabricatorPHPPreflightSetupCheck extends PhabricatorSetupCheck {
|
|||
}
|
||||
|
||||
protected function executeChecks() {
|
||||
if (version_compare(phpversion(), 7, '>=')) {
|
||||
if (version_compare(phpversion(), 7, '>=') &&
|
||||
version_compare(phpversion(), 7.1, '<')) {
|
||||
$message = pht(
|
||||
'This version of Phabricator does not support PHP 7. You '.
|
||||
'are running PHP %s.',
|
||||
'This version of Phabricator does not support PHP 7.0. You '.
|
||||
'are running PHP %s. Upgrade to PHP 7.1 or newer.',
|
||||
phpversion());
|
||||
|
||||
$this->newIssue('php.version7')
|
||||
->setIsFatal(true)
|
||||
->setName(pht('PHP 7 Not Supported'))
|
||||
->setName(pht('PHP 7.0 Not Supported'))
|
||||
->setMessage($message)
|
||||
->addLink(
|
||||
'https://phurl.io/u/php7',
|
||||
|
|
Loading…
Reference in a new issue