Herald - unleash some recursive madness!

Summary: turn on herald rules ability to specify other herald rules. Fixes T4294.

Test Plan: made a rule to be cc'd on new tasks. made another rule to flag a task if it contained "test test" in the title AND the cc'd rule for new tasks matched. Made some new tasks and verified new "test test" tasks were flagged.

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4294

Differential Revision: https://secure.phabricator.com/D8157

src/applications/herald/adapter/HeraldAdapter.php

@@ -194,6 +194,7 @@ abstract class HeraldAdapter {
   public function getFields() {
     return array(
       self::FIELD_ALWAYS,
+      self::FIELD_RULE,
     );
   }
 

src/applications/herald/adapter/HeraldCommitAdapter.php

@@ -107,7 +107,6 @@ final class HeraldCommitAdapter extends HeraldAdapter {
         self::FIELD_DIFF_ADDED_CONTENT,
         self::FIELD_DIFF_REMOVED_CONTENT,
         self::FIELD_DIFF_ENORMOUS,
-        self::FIELD_RULE,
         self::FIELD_AFFECTED_PACKAGE,
         self::FIELD_AFFECTED_PACKAGE_OWNER,
         self::FIELD_NEED_AUDIT_FOR_PACKAGE,

src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php

@@ -69,10 +69,9 @@ final class HeraldDifferentialRevisionAdapter extends HeraldAdapter {
         self::FIELD_DIFF_CONTENT,
         self::FIELD_DIFF_ADDED_CONTENT,
         self::FIELD_DIFF_REMOVED_CONTENT,
-        self::FIELD_RULE,
         self::FIELD_AFFECTED_PACKAGE,
         self::FIELD_AFFECTED_PACKAGE_OWNER,
-        self::FIELD_OBJECT_IS_NEW,
+        self::FIELD_IS_NEW_OBJECT,
       ),
       parent::getFields());
   }

src/applications/herald/adapter/HeraldPholioMockAdapter.php

@@ -59,7 +59,7 @@ final class HeraldPholioMockAdapter extends HeraldAdapter {
         self::FIELD_BODY,
         self::FIELD_AUTHOR,
         self::FIELD_CC,
-        self::FIELD_OBJECT_IS_NEW,
+        self::FIELD_IS_NEW_OBJECT,
       ),
       parent::getFields());
   }

src/applications/herald/storage/HeraldRule.php

@@ -17,7 +17,7 @@ final class HeraldRule extends HeraldDAO
   protected $isDisabled = 0;
   protected $triggerObjectPHID;
 
-  protected $configVersion = 29;
+  protected $configVersion = 30;
 
   // phids for which this rule has been applied
   private $ruleApplied = self::ATTACHABLE;