revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-11 15:21:03 +01:00
Code Issues Releases Wiki Activity

Not require confirmation for revision subscribe and unsubscribe

Browse source 
Summary: Regression to original behavior.

Test Plan: Clicked on it twice, didn't see confirmation dialog.

Reviewers: epriestley, codeblock

Reviewed By: codeblock

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4788
This commit is contained in:
vrana 2013-02-01 17:22:48 -08:00
parent bf3db6e946
commit a808133bc8
2 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/differential/controller/DifferentialRevisionViewController.php
View file

@ -498,7 +498,6 @@ final class DifferentialRevisionViewController extends DifferentialController {
'href' => "/differential/subscribe/{$action}/{$revision_id}/", 'href' => "/differential/subscribe/{$action}/{$revision_id}/",
'name' => $viewer_is_cc ? pht('Unsubscribe') : pht('Subscribe'), 'name' => $viewer_is_cc ? pht('Unsubscribe') : pht('Subscribe'),
'instant' => true, 'instant' => true,
'sigil' => 'workflow',
); );
} else { } else {
$links[] = array( $links[] = array(

1
src/applications/differential/view/DifferentialRevisionDetailView.php
View file

@ -52,6 +52,7 @@ final class DifferentialRevisionDetailView extends AphrontView {
->setName($action['name']) ->setName($action['name'])
->setHref(idx($action, 'href')) ->setHref(idx($action, 'href'))
->setWorkflow(idx($action, 'sigil') == 'workflow') ->setWorkflow(idx($action, 'sigil') == 'workflow')
->setRenderAsForm(!empty($action['instant']))
->setUser($user) ->setUser($user)
->setDisabled(idx($action, 'disabled', false)); ->setDisabled(idx($action, 'disabled', false));
$actions->addAction($obj); $actions->addAction($obj);