revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-20 04:20:55 +01:00
Code Issues Releases Wiki Activity

Fix (?) an issue with CCs not being written into commit messages properly

Browse source 
Summary: Report from @zeeg, I think this is the root issue. Currently, if a project is CC'd we'll write "CC: projectname", but should write "CC: #projectname".

Test Plan: Verified that we now write "CC: #projectname".

Reviewers: btrahan, zeeg

Reviewed By: zeeg

CC: zeeg, aran

Differential Revision: https://secure.phabricator.com/D8296
This commit is contained in:
epriestley 2014-02-21 12:56:38 -08:00
parent 20a3ee24f9
commit a84cc1ab73
2 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/field/specification/DifferentialCCsFieldSpecification.php
View file

@ -90,7 +90,7 @@ final class DifferentialCCsFieldSpecification
foreach ($this->ccs as $phid) { foreach ($this->ccs as $phid) {
$handle = $this->getHandle($phid); $handle = $this->getHandle($phid);
if ($handle->isComplete()) { if ($handle->isComplete()) {
$names[] = $handle->getName(); $names[] = $handle->getObjectName();
} }
} }
return implode(', ', $names); return implode(', ', $names);

2
src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
View file

@ -130,8 +130,6 @@ final class DifferentialReviewersFieldSpecification
return null; return null;
} }
$project_type = PhabricatorProjectPHIDTypeProject::TYPECONST;
$names = array(); $names = array();
foreach ($this->reviewers as $phid) { foreach ($this->reviewers as $phid) {
$names[] = $this->getHandle($phid)->getObjectName(); $names[] = $this->getHandle($phid)->getObjectName();