mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 14:00:56 +01:00
Fix an issue where rejecting reviewers weren't powerful enough
Summary: Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject". Set the "older reject" flag properly when we find a non-current reject. Test Plan: - User A accepts a revision. - User B rejects it. - Author updates it. - Before patch: incorrectly transitions to "accepted" ("older" reject is ignored). - After patch: correctly transitions to "needs review". Reviewers: chad Reviewed By: chad Differential Revision: https://secure.phabricator.com/D17653
This commit is contained in:
parent
28941b3105
commit
af1d494d66
1 changed files with 2 additions and 0 deletions
|
@ -672,6 +672,8 @@ final class DifferentialTransactionEditor
|
|||
$active_phid = $active_diff->getPHID();
|
||||
if ($reviewer->isRejected($active_phid)) {
|
||||
$has_rejecting_reviewer = true;
|
||||
} else {
|
||||
$has_rejecting_older_reviewer = true;
|
||||
}
|
||||
break;
|
||||
case DifferentialReviewerStatus::STATUS_REJECTED_OLDER:
|
||||
|
|
Loading…
Reference in a new issue