revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-02 02:40:58 +01:00
Code Issues Releases Wiki Activity

Fix Diffusion change view header

Browse source 
Summary: See D7162. This was like 99% my fault. Just provide a header; the new ones look pretty reasonable.

Test Plan: Viewed Diffusion change view, no exception.

Reviewers: vrana, chad

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D7183
This commit is contained in:
epriestley 2013-09-30 17:49:15 -07:00
parent ca7a792794
commit b21f197a98
2 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/differential/view/DifferentialChangesetListView.php
View file

@ -194,11 +194,8 @@ final class DifferentialChangesetListView extends AphrontView {
)); ));
} }
$header = null; $header = id(new PHUIHeaderView())
if ($this->getTitle() !== null) { ->setHeader($this->getTitle());
$header = id(new PHUIHeaderView())
->setHeader($this->getTitle());
}
$content = phutil_tag( $content = phutil_tag(
'div', 'div',

1
src/applications/diffusion/controller/DiffusionChangeController.php
View file

@ -37,6 +37,7 @@ final class DiffusionChangeController extends DiffusionController {
); );
$changeset_view = new DifferentialChangesetListView(); $changeset_view = new DifferentialChangesetListView();
$changeset_view->setTitle(pht('Change'));
$changeset_view->setChangesets($changesets); $changeset_view->setChangesets($changesets);
$changeset_view->setVisibleChangesets($changesets); $changeset_view->setVisibleChangesets($changesets);
$changeset_view->setRenderingReferences( $changeset_view->setRenderingReferences(