revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Add role=dialog to all dialogs

Browse source 
Summary: Seen some complaints about usability here, adding role=dialog to improve when these trigger.

Test Plan: Turn on Voiceover, tab over to log out link, here proper dialog title and text before highlighted submit button.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15993
This commit is contained in:
Chad Little 2016-05-31 12:15:23 -07:00
parent e64dfbcbd8
commit b23c85b169
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/view/AphrontDialogView.php
View file

@ -276,6 +276,7 @@ final class AphrontDialogView
$attributes = array( $attributes = array(
'class' => implode(' ', $classes), 'class' => implode(' ', $classes),
'sigil' => 'jx-dialog', 'sigil' => 'jx-dialog',
'role' => 'dialog',
); );
$form_attributes = array( $form_attributes = array(