revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-25 15:00:58 +01:00
Code Issues Releases Wiki Activity

Fix bad button construction in Owners

Browse source 
Summary: Fixes T7618. The "button" needs to be a PHUIButtonView later on.

Test Plan: Forced condition, loaded page, saw button instead of fatal.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7618

Differential Revision: https://secure.phabricator.com/D12108
This commit is contained in:
epriestley 2015-03-18 07:08:50 -07:00
parent 1e4be36484
commit b5238dc080
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/applications/owners/controller/PhabricatorOwnersDetailController.php
View file

@ -157,13 +157,10 @@ final class PhabricatorOwnersDetailController
$commit_views[] = array( $commit_views[] = array(
'view' => $view, 'view' => $view,
'header' => pht('Commits in this Package that Need Attention'), 'header' => pht('Commits in this Package that Need Attention'),
'button' => phutil_tag( 'button' => id(new PHUIButtonView())
'a', ->setTag('a')
array( ->setHref($commit_uri->alter('status', 'open'))
'href' => $commit_uri->alter('status', 'open'), ->setText(pht('View All Problem Commits')),
'class' => 'button grey',
),
pht('View All Problem Commits')),
); );
} }