revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 13:30:55 +01:00
Code Issues Releases Wiki Activity

Explicitly show that "escape" closes dialogs in Phabricator

Browse source 
Summary: See T382. I think bill also asked about this (T308); there's no way to
figure it out right now.
Test Plan:
  - Hit "?", verified the dialog now reveals that escape closes it.
  - Hit escape, dialog vanished.

Reviewed By: jungejason
Reviewers: fzamore, bill, codeblock, jungejason, tuomaspelkonen, aran
CC: aran, jungejason
Differential Revision: 763
This commit is contained in:
epriestley 2011-08-02 07:00:24 -07:00
parent 9e2231f6d6
commit b5ada76ab0
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/applications/help/controller/keyboardshortcut/PhabricatorHelpKeyboardShortcutController.php
View file

@ -29,6 +29,14 @@ class PhabricatorHelpKeyboardShortcutController
return new Aphront400Response(); return new Aphront400Response();
} }
// There have been at least two users asking for a keyboard shortcut to
// close the dialog, so be explicit that escape works since it isn't
// terribly discoverable.
$keys[] = array(
'keys' => array('esc'),
'description' => 'Close any dialog, including this one.',
);
$rows = array(); $rows = array();
foreach ($keys as $shortcut) { foreach ($keys as $shortcut) {
$keystrokes = array(); $keystrokes = array();