revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Remove unused revisionID and whitespace properties from diff TOC view

Browse source 
Summary: Ref T2183. These properties are not used and not useful.

Test Plan: Grepped for callsites and uses. Loaded revisions.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2183

Differential Revision: https://secure.phabricator.com/D13906
This commit is contained in:
epriestley 2015-08-15 10:54:27 -07:00
parent 74bf0d6ec6
commit bb0d13345d
2 changed files with 0 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/controller/DifferentialRevisionViewController.php
View file

@ -359,8 +359,6 @@ final class DifferentialRevisionViewController extends DifferentialController {
}
$toc_view->setDiff($target);
$toc_view->setUser($user);
$toc_view->setRevisionID($revision->getID());
$toc_view->setWhitespace($whitespace);
$comment_form = null;
if (!$viewer_is_anonymous) {

12
src/applications/differential/view/DifferentialDiffTableOfContentsView.php
View file

@ -8,8 +8,6 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
private $repository;
private $diff;
private $renderURI = '/differential/changeset/';
private $revisionID;
private $whitespace;
private $coverageMap;
public function setChangesets($changesets) {
@ -42,16 +40,6 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
return $this;
}
public function setRevisionID($revision_id) {
$this->revisionID = $revision_id;
return $this;
}
public function setWhitespace($whitespace) {
$this->whitespace = $whitespace;
return $this;
}
public function render() {
$this->requireResource('differential-core-view-css');