revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-31 08:58:20 +01:00
Code Issues Releases Wiki Activity

Fix incorrect rendering of "Spaces" dropdown control when configuring EditEngine defaults

Browse source 
Summary:
Ref T10004. This could sometimes pass `false`, which counts as disabled.

Instead, pass `null` explicitly.

Test Plan: Edited default space on an EditEngine form.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10004

Differential Revision: https://secure.phabricator.com/D14858
This commit is contained in:
epriestley 2015-12-22 18:20:23 -08:00
parent 15550b5582
commit bb8cf8eca8
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/view/form/control/AphrontFormPolicyControl.php
View file

@ -351,7 +351,7 @@ final class AphrontFormPolicyControl extends AphrontFormControl {
$viewer, $viewer,
$space_phid), $space_phid),
array( array(
'disabled' => $this->getDisabled(), 'disabled' => ($this->getDisabled() ? 'disabled' : null),
'name' => 'spacePHID', 'name' => 'spacePHID',
'class' => 'aphront-space-select-control-knob', 'class' => 'aphront-space-select-control-knob',
)); ));