revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 21:02:41 +01:00
Code Issues Releases Wiki Activity

Fix a final (?) task field issue which slipped through the cracks

Browse source 
Summary:
Derped this one up; while my testing was successful in preventing runaway
attaching I missed the bit where it doesn't actually work.

This resolves the "Unknown Object" link seen on T661.

Test Plan:
  - Created two new revisions, each attached to a local task.
  - Verified that they attached additively, Maniphest and Differential were
linked to the right places, and nothign else bad happened.

Reviewers: btrahan, fratrik

Reviewed By: fratrik

CC: aran, fratrik, btrahan

Differential Revision: 1181
This commit is contained in:
epriestley 2011-12-07 06:58:16 -08:00
parent d13906ff96
commit bd12a2b839
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/field/specification/maniphesttasks/DifferentialManiphestTasksFieldSpecification.php
View file

@ -86,7 +86,7 @@ final class DifferentialManiphestTasksFieldSpecification
if (empty($new[$attach_type])) { if (empty($new[$attach_type])) {
$new[$attach_type] = array(); $new[$attach_type] = array();
} }
$new[$attach_type][$revision->getPHID] = array(); $new[$attach_type][$revision->getPHID()] = array();
$transaction->setNewValue($new); $transaction->setNewValue($new);
$maniphest_editor->applyTransactions($task, array($transaction)); $maniphest_editor->applyTransactions($task, array($transaction));