revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Remove "admin page" color/styles

Browse source 
Summary: These haven't had any effect since the redesign, and we're moving to a more granular policy model so it probably doesn't make sense to ever restore them.

Test Plan: Grepped for "admin" and removed all relevant code.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3710
This commit is contained in:
epriestley 2012-10-16 10:33:37 -07:00
parent b9f84ebba8
commit c02a588b4e
3 changed files with 0 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/base/controller/PhabricatorController.php
View file

@ -139,11 +139,6 @@ abstract class PhabricatorController extends AphrontController {
$view = new PhabricatorStandardPageView(); $view = new PhabricatorStandardPageView();
$view->setRequest($this->getRequest()); $view->setRequest($this->getRequest());
$view->setController($this); $view->setController($this);
if ($this->shouldRequireAdmin()) {
$view->setIsAdminInterface(true);
}
return $view; return $view;
} }

1
src/applications/herald/controller/HeraldController.php
View file

@ -27,7 +27,6 @@ abstract class HeraldController extends PhabricatorController {
$page->setGlyph("\xE2\x98\xBF"); $page->setGlyph("\xE2\x98\xBF");
$page->appendChild($view); $page->appendChild($view);
$page->setIsAdminInterface(idx($data, 'admin'));
$response = new AphrontWebpageResponse(); $response = new AphrontWebpageResponse();
return $response->setContent($page->render()); return $response->setContent($page->render());

21
src/view/page/PhabricatorStandardPageView.php
View file

@ -24,19 +24,13 @@ final class PhabricatorStandardPageView extends AphrontPageView {
private $bodyContent; private $bodyContent;
private $menuContent; private $menuContent;
private $request; private $request;
private $isAdminInterface;
private $showChrome = true; private $showChrome = true;
private $isFrameable = false; private $isFrameable = false;
private $disableConsole; private $disableConsole;
private $searchDefaultScope; private $searchDefaultScope;
private $pageObjects = array(); private $pageObjects = array();
private $controller; private $controller;
private $deviceReady;
public function setDeviceReady($device_ready) {
$this->deviceReady = $device_ready;
return $this;
}
public function setController(AphrontController $controller) { public function setController(AphrontController $controller) {
$this->controller = $controller; $this->controller = $controller;
@ -47,15 +41,6 @@ final class PhabricatorStandardPageView extends AphrontPageView {
return $this->controller; return $this->controller;
} }
public function setIsAdminInterface($is_admin_interface) {
$this->isAdminInterface = $is_admin_interface;
return $this;
}
public function getIsAdminInterface() {
return $this->isAdminInterface;
}
public function setRequest($request) { public function setRequest($request) {
$this->request = $request; $this->request = $request;
return $this; return $this;
@ -303,11 +288,6 @@ final class PhabricatorStandardPageView extends AphrontPageView {
} }
} }
$admin_class = null;
if ($this->getIsAdminInterface()) {
$admin_class = 'phabricator-admin-page-view';
}
$header_chrome = null; $header_chrome = null;
$footer_chrome = null; $footer_chrome = null;
if ($this->getShowChrome()) { if ($this->getShowChrome()) {
@ -341,7 +321,6 @@ final class PhabricatorStandardPageView extends AphrontPageView {
$classes = array( $classes = array(
'phabricator-standard-page', 'phabricator-standard-page',
$admin_class,
$device_guess, $device_guess,
); );
$classes = implode(' ', $classes); $classes = implode(' ', $classes);