revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-19 16:58:48 +02:00
Code Issues Releases Wiki Activity

Fix bin/accountadmin when not making changes

Browse source 
Summary: If you go through the `accountadmin` flow and change nothing, you get an exception about the transaction not having any effect. Instead, let the `applyTransactions` call continue even on no effect.

Test Plan: Ran `accountadmin` without changing anything for an existing user. No longer got an exception about no-effect transactions.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D20009
This commit is contained in:
Austin McKinley 2019-01-21 12:34:16 -08:00
parent 6138d5885d
commit c756bf3476
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
scripts/user/account_admin.php
View file

@ -218,6 +218,7 @@ $user->openTransaction();
->setActor($actor) ->setActor($actor)
->setActingAsPHID($people_application_phid) ->setActingAsPHID($people_application_phid)
->setContentSource($content_source) ->setContentSource($content_source)
->setContinueOnNoEffect(true)
->setContinueOnMissingFields(true); ->setContinueOnMissingFields(true);
$transaction_editor->applyTransactions($user, $xactions); $transaction_editor->applyTransactions($user, $xactions);