1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 21:02:41 +01:00

[Redesign] Fix filetree view in Differential

Summary: Ref T8099. We removed the background column, so this JS wasn't able to fire and make the filetree movable.

Test Plan: Set Filetree on, resize it. Scroll through a diff.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13048
This commit is contained in:
Chad Little 2015-05-28 11:32:17 -07:00
parent d60f763c89
commit ca50f8e9ef
2 changed files with 13 additions and 21 deletions

View file

@ -8,7 +8,7 @@
return array( return array(
'names' => array( 'names' => array(
'core.pkg.css' => '75121d30', 'core.pkg.css' => '75121d30',
'core.pkg.js' => '9db3e620', 'core.pkg.js' => 'e4f47dfd',
'darkconsole.pkg.js' => 'e7393ebb', 'darkconsole.pkg.js' => 'e7393ebb',
'differential.pkg.css' => 'bb338e4b', 'differential.pkg.css' => 'bb338e4b',
'differential.pkg.js' => '63a77807', 'differential.pkg.js' => '63a77807',
@ -451,7 +451,7 @@ return array(
'rsrc/js/core/behavior-more.js' => 'a80d0378', 'rsrc/js/core/behavior-more.js' => 'a80d0378',
'rsrc/js/core/behavior-object-selector.js' => '49b73b36', 'rsrc/js/core/behavior-object-selector.js' => '49b73b36',
'rsrc/js/core/behavior-oncopy.js' => '2926fff2', 'rsrc/js/core/behavior-oncopy.js' => '2926fff2',
'rsrc/js/core/behavior-phabricator-nav.js' => '14d7a8b8', 'rsrc/js/core/behavior-phabricator-nav.js' => '56a1ca03',
'rsrc/js/core/behavior-phabricator-remarkup-assist.js' => 'e32d14ab', 'rsrc/js/core/behavior-phabricator-remarkup-assist.js' => 'e32d14ab',
'rsrc/js/core/behavior-refresh-csrf.js' => '7814b593', 'rsrc/js/core/behavior-refresh-csrf.js' => '7814b593',
'rsrc/js/core/behavior-remarkup-preview.js' => 'f7379f45', 'rsrc/js/core/behavior-remarkup-preview.js' => 'f7379f45',
@ -597,7 +597,7 @@ return array(
'javelin-behavior-phabricator-keyboard-pager' => 'a8da01f0', 'javelin-behavior-phabricator-keyboard-pager' => 'a8da01f0',
'javelin-behavior-phabricator-keyboard-shortcuts' => 'd75709e6', 'javelin-behavior-phabricator-keyboard-shortcuts' => 'd75709e6',
'javelin-behavior-phabricator-line-linker' => '1499a8cb', 'javelin-behavior-phabricator-line-linker' => '1499a8cb',
'javelin-behavior-phabricator-nav' => '14d7a8b8', 'javelin-behavior-phabricator-nav' => '56a1ca03',
'javelin-behavior-phabricator-notification-example' => '8ce821c5', 'javelin-behavior-phabricator-notification-example' => '8ce821c5',
'javelin-behavior-phabricator-object-selector' => '49b73b36', 'javelin-behavior-phabricator-object-selector' => '49b73b36',
'javelin-behavior-phabricator-oncopy' => '2926fff2', 'javelin-behavior-phabricator-oncopy' => '2926fff2',
@ -913,16 +913,6 @@ return array(
'javelin-request', 'javelin-request',
'javelin-uri', 'javelin-uri',
), ),
'14d7a8b8' => array(
'javelin-behavior',
'javelin-behavior-device',
'javelin-stratcom',
'javelin-dom',
'javelin-magical-init',
'javelin-vector',
'javelin-request',
'javelin-util',
),
'16c695bf' => array( '16c695bf' => array(
'javelin-behavior', 'javelin-behavior',
'javelin-dom', 'javelin-dom',
@ -1192,6 +1182,16 @@ return array(
'javelin-vector', 'javelin-vector',
'javelin-dom', 'javelin-dom',
), ),
'56a1ca03' => array(
'javelin-behavior',
'javelin-behavior-device',
'javelin-stratcom',
'javelin-dom',
'javelin-magical-init',
'javelin-vector',
'javelin-request',
'javelin-util',
),
58562350 => array( 58562350 => array(
'javelin-dom', 'javelin-dom',
'javelin-util', 'javelin-util',

View file

@ -17,7 +17,6 @@ JX.behavior('phabricator-nav', function(config) {
var local = JX.$(config.localID); var local = JX.$(config.localID);
var main = JX.$(config.mainID); var main = JX.$(config.mainID);
var drag = JX.$(config.dragID); var drag = JX.$(config.dragID);
var background = JX.$(config.backgroundID);
// - Flexible Navigation Column ------------------------------------------------ // - Flexible Navigation Column ------------------------------------------------
@ -44,12 +43,6 @@ JX.behavior('phabricator-nav', function(config) {
width: JX.Vector.getDim(local).x, width: JX.Vector.getDim(local).x,
minWidth: 1 minWidth: 1
}, },
{
element: background,
parameter: 'width',
start: JX.Vector.getDim(background).x,
minWidth: 1
},
{ {
element: drag, element: drag,
parameter: 'left', parameter: 'left',
@ -106,7 +99,6 @@ JX.behavior('phabricator-nav', function(config) {
function resetdrag() { function resetdrag() {
local.style.width = ''; local.style.width = '';
background.style.width = '';
drag.style.left = ''; drag.style.left = '';
content.style.marginLeft = ''; content.style.marginLeft = '';
} }