revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-17 20:32:41 +01:00
Code Issues Releases Wiki Activity

Remove "passwordHash" and "passwordSalt" from User objects

Browse source 
Summary:
Ref T13043. After D18903, this data has migrated to shared infrastructure and has no remaining readers or writers.

Just delete it now, since the cost of a mistake here is very small (users need to "Forgot Password?" and pick a new password).

Test Plan: Grepped for `passwordHash`, `passwordSalt`, and variations.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13043

Differential Revision: https://secure.phabricator.com/D18904
This commit is contained in:
epriestley 2018-01-21 17:17:36 -08:00
parent abc030fa00
commit cab2bba6f2
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
resources/sql/autopatches/20180121.auth.05.accountnuke.sql Normal file
View file

@ -0,0 +1,5 @@
ALTER TABLE {$NAMESPACE}_user.user
DROP passwordSalt;
ALTER TABLE {$NAMESPACE}_user.user
DROP passwordHash;

4
src/applications/people/storage/PhabricatorUser.php
View file

@ -29,8 +29,6 @@ final class PhabricatorUser
protected $userName; protected $userName;
protected $realName; protected $realName;
protected $passwordSalt;
protected $passwordHash;
protected $profileImagePHID; protected $profileImagePHID;
protected $defaultProfileImagePHID; protected $defaultProfileImagePHID;
protected $defaultProfileImageVersion; protected $defaultProfileImageVersion;
@ -217,8 +215,6 @@ final class PhabricatorUser
self::CONFIG_COLUMN_SCHEMA => array( self::CONFIG_COLUMN_SCHEMA => array(
'userName' => 'sort64', 'userName' => 'sort64',
'realName' => 'text128', 'realName' => 'text128',
'passwordSalt' => 'text32?',
'passwordHash' => 'text128?',
'profileImagePHID' => 'phid?', 'profileImagePHID' => 'phid?',
'conduitCertificate' => 'text255', 'conduitCertificate' => 'text255',
'isSystemAgent' => 'bool', 'isSystemAgent' => 'bool',