1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00

Consistent panels for account settings.

Summary: Sets all panels to full width and no backgrounds in settings for consistency.

Test Plan: Check each page width.

Reviewers: epriestley, codeblock, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4460
This commit is contained in:
Chad Little 2013-01-16 07:49:05 -08:00
parent e974ffea7f
commit cba5a866f8
11 changed files with 15 additions and 11 deletions

View file

@ -90,8 +90,8 @@ final class PhabricatorSettingsPanelAccount
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setHeader('Account Settings'); $panel->setHeader('Account Settings');
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
$panel->appendChild($form); $panel->appendChild($form);
$panel->setNoBackground();
return array( return array(
$notice, $notice,

View file

@ -78,7 +78,7 @@ final class PhabricatorSettingsPanelConduit
$cert = new AphrontPanelView(); $cert = new AphrontPanelView();
$cert->setHeader('Arcanist Certificate'); $cert->setHeader('Arcanist Certificate');
$cert->appendChild($cert_form); $cert->appendChild($cert_form);
$cert->setWidth(AphrontPanelView::WIDTH_FORM); $cert->setNoBackground();
$regen_form = new AphrontFormView(); $regen_form = new AphrontFormView();
$regen_form $regen_form
@ -96,7 +96,7 @@ final class PhabricatorSettingsPanelConduit
$regen = new AphrontPanelView(); $regen = new AphrontPanelView();
$regen->setHeader('Regenerate Certificate'); $regen->setHeader('Regenerate Certificate');
$regen->appendChild($regen_form); $regen->appendChild($regen_form);
$regen->setWidth(AphrontPanelView::WIDTH_FORM); $regen->setNoBackground();
return array( return array(
$notice, $notice,

View file

@ -145,9 +145,9 @@ EXAMPLE;
->setValue('Save Preferences')); ->setValue('Save Preferences'));
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setWidth(AphrontPanelView::WIDTH_WIDE);
$panel->setHeader('Display Preferences'); $panel->setHeader('Display Preferences');
$panel->appendChild($form); $panel->appendChild($form);
$panel->setNoBackground();
$error_view = null; $error_view = null;
if ($request->getStr('saved') === 'true') { if ($request->getStr('saved') === 'true') {

View file

@ -144,6 +144,7 @@ final class PhabricatorSettingsPanelEmailAddresses
} }
$view->setHeader('Email Addresses'); $view->setHeader('Email Addresses');
$view->appendChild($table); $view->appendChild($table);
$view->setNoBackground();
return $view; return $view;
} }

View file

@ -201,8 +201,8 @@ final class PhabricatorSettingsPanelEmailPreferences
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setHeader('Email Preferences'); $panel->setHeader('Email Preferences');
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
$panel->appendChild($form); $panel->appendChild($form);
$panel->setNoBackground();
return id(new AphrontNullView()) return id(new AphrontNullView())
->appendChild( ->appendChild(

View file

@ -70,7 +70,8 @@ final class PhabricatorSettingsPanelLDAP
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setHeader('LDAP Account Settings'); $panel->setHeader('LDAP Account Settings');
$panel->setWidth(AphrontPanelView::WIDTH_FORM); $panel->setNoBackground();
foreach ($forms as $name => $form) { foreach ($forms as $name => $form) {
if ($name) { if ($name) {
$panel->appendChild('<br /><h1>'.$name.'</h1><br />'); $panel->appendChild('<br /><h1>'.$name.'</h1><br />');

View file

@ -204,7 +204,8 @@ final class PhabricatorSettingsPanelOAuth
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setHeader($provider_name.' Account Settings'); $panel->setHeader($provider_name.' Account Settings');
$panel->setWidth(AphrontPanelView::WIDTH_FORM); $panel->setNoBackground();
foreach ($forms as $name => $form) { foreach ($forms as $name => $form) {
if ($name) { if ($name) {
$panel->appendChild('<br /><h1>'.$name.'</h1><br />'); $panel->appendChild('<br /><h1>'.$name.'</h1><br />');

View file

@ -160,8 +160,8 @@ final class PhabricatorSettingsPanelPassword
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setHeader('Change Password'); $panel->setHeader('Change Password');
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
$panel->appendChild($form); $panel->appendChild($form);
$panel->setNoBackground();
return array( return array(
$notice, $notice,

View file

@ -198,7 +198,7 @@ final class PhabricatorSettingsPanelProfile
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setHeader('Edit Profile Details'); $panel->setHeader('Edit Profile Details');
$panel->appendChild($form); $panel->appendChild($form);
$panel->setWidth(AphrontPanelView::WIDTH_FORM); $panel->setNoBackground();
return array( return array(
$error_view, $error_view,

View file

@ -154,8 +154,8 @@ final class PhabricatorSettingsPanelSSHKeys
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setHeader($header); $panel->setHeader($header);
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
$panel->appendChild($form); $panel->appendChild($form);
$panel->setNoBackground();
return id(new AphrontNullView()) return id(new AphrontNullView())
->appendChild( ->appendChild(
@ -229,6 +229,7 @@ final class PhabricatorSettingsPanelSSHKeys
'Add New Public Key')); 'Add New Public Key'));
$panel->setHeader('SSH Public Keys'); $panel->setHeader('SSH Public Keys');
$panel->appendChild($table); $panel->appendChild($table);
$panel->setNoBackground();
return $panel; return $panel;
} }

View file

@ -52,9 +52,9 @@ final class PhabricatorSettingsPanelSearchPreferences
->setValue('Save')); ->setValue('Save'));
$panel = new AphrontPanelView(); $panel = new AphrontPanelView();
$panel->setWidth(AphrontPanelView::WIDTH_FORM);
$panel->setHeader('Search Preferences'); $panel->setHeader('Search Preferences');
$panel->appendChild($form); $panel->appendChild($form);
$panel->setNoBackground();
$error_view = null; $error_view = null;
if ($request->getStr('saved') === 'true') { if ($request->getStr('saved') === 'true') {