revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-16 16:58:38 +01:00
Code Issues Releases Wiki Activity

Remove some array typehints for passing around

Browse source 
Summary: See discussion at https://secure.phabricator.com/D19492#241996

Test Plan: Refreshed a few Diffusion tabs; nothing broke.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D19578
This commit is contained in:
Austin McKinley 2018-08-13 15:37:04 -07:00
parent 3b05e920e0
commit cc1def6cea
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/repository/storage/PhabricatorRepositoryCommit.php
View file

@ -446,7 +446,7 @@ final class PhabricatorRepositoryCommit
* the migration to using identities, update this method to remove the * the migration to using identities, update this method to remove the
* fallback. See T12164 for details. * fallback. See T12164 for details.
*/ */
public function renderAnyCommitter(PhabricatorUser $viewer, array $handles) { public function renderAnyCommitter(PhabricatorUser $viewer, $handles) {
$committer = $this->renderCommitter($viewer, $handles); $committer = $this->renderCommitter($viewer, $handles);
if ($committer) { if ($committer) {
return $committer; return $committer;
@ -455,7 +455,7 @@ final class PhabricatorRepositoryCommit
return $this->renderAuthor($viewer, $handles); return $this->renderAuthor($viewer, $handles);
} }
public function renderCommitter(PhabricatorUser $viewer, array $handles) { public function renderCommitter(PhabricatorUser $viewer, $handles) {
$committer_phid = $this->getCommitterDisplayPHID(); $committer_phid = $this->getCommitterDisplayPHID();
if ($committer_phid) { if ($committer_phid) {
return $handles[$committer_phid]->renderLink(); return $handles[$committer_phid]->renderLink();
@ -470,7 +470,7 @@ final class PhabricatorRepositoryCommit
return null; return null;
} }
public function renderAuthor(PhabricatorUser $viewer, array $handles) { public function renderAuthor(PhabricatorUser $viewer, $handles) {
$author_phid = $this->getAuthorDisplayPHID(); $author_phid = $this->getAuthorDisplayPHID();
if ($author_phid) { if ($author_phid) {
return $handles[$author_phid]->renderLink(); return $handles[$author_phid]->renderLink();

2
src/applications/subscriptions/view/SubscriptionListDialogBuilder.php
View file

@ -58,7 +58,7 @@ final class SubscriptionListDialogBuilder extends Phobject {
->addCancelButton($object_handle->getURI(), pht('Close')); ->addCancelButton($object_handle->getURI(), pht('Close'));
} }
private function buildBody(PhabricatorUser $viewer, array $handles) { private function buildBody(PhabricatorUser $viewer, $handles) {
$list = id(new PHUIObjectItemListView()) $list = id(new PHUIObjectItemListView())
->setUser($viewer); ->setUser($viewer);