revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 16:22:43 +01:00
Code Issues Releases Wiki Activity

Resolve implicit fallthrough in Phabricator

Browse source 
Summary: New implicit fallthrough linter detected a few issues; none of these have behavioral impacts but they can clearly be tightened up. See D1824.

Test Plan: Lint; inspection.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1825
This commit is contained in:
epriestley 2012-03-08 12:46:29 -08:00
parent 1c80a4eb58
commit ce919b0822
4 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
scripts/repository/reparse.php
View file

@ -2,7 +2,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -63,6 +63,7 @@ foreach ($args as $arg) {
break; break;
default: default:
usage("Unknown flag '{$arg}'."); usage("Unknown flag '{$arg}'.");
break;
} }
} else { } else {
if ($reparse_what) { if ($reparse_what) {

1
src/applications/phid/handle/PhabricatorObjectHandle.php
View file

@ -223,6 +223,7 @@ class PhabricatorObjectHandle {
break; break;
default: default:
$name = $this->getFullName(); $name = $this->getFullName();
break;
} }
return $name; return $name;
} }

3
src/storage/qsprintf/qsprintf.php
View file

@ -1,7 +1,7 @@
<?php <?php
/* /*
* Copyright 2011 Facebook, Inc. * Copyright 2012 Facebook, Inc.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -264,6 +264,7 @@ function _qsprintf_check_type($value, $type, $query) {
break; break;
default: default:
_qsprintf_check_scalar_type($value, $type, $query); _qsprintf_check_scalar_type($value, $type, $query);
break;
} }
} }

2
webroot/index.php
View file

@ -220,7 +220,7 @@ function phabricator_detect_bad_base_uri() {
case 'https': case 'https':
break; break;
default: default:
phabricator_fatal_config_error( return phabricator_fatal_config_error(
"'phabricator.base-uri' is set to '{$conf}', which is invalid. ". "'phabricator.base-uri' is set to '{$conf}', which is invalid. ".
"The URI must start with 'http://' or 'https://'."); "The URI must start with 'http://' or 'https://'.");
} }