1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 14:30:56 +01:00

Add "tabindex" to Remarkup reference lists

Summary:
Prevent keyboard focus of these links so we don't disrupt tab order from
comments to "Submit".

Arguably I should make a "function" for this or something but there's nowhere to
really put it that makes any sense right now.

Test Plan: Verified Firefox skips these links in tab order.

Reviewers: fratrik, btrahan, jungejason

Reviewed By: fratrik

CC: aran, fratrik

Maniphest Tasks: T661

Differential Revision: 1180
This commit is contained in:
epriestley 2011-12-07 06:46:37 -08:00
parent 4fd81150be
commit d13906ff96
3 changed files with 6 additions and 2 deletions

View file

@ -110,9 +110,10 @@ final class DifferentialAddCommentView extends AphrontView {
array( array(
'href' => PhabricatorEnv::getDoclink( 'href' => PhabricatorEnv::getDoclink(
'article/Remarkup_Reference.html'), 'article/Remarkup_Reference.html'),
'tabindex' => '-1',
'target' => '_blank', 'target' => '_blank',
), ),
'Remarkup Reference'))) 'Formatting Reference')))
->appendChild( ->appendChild(
id(new AphrontFormSubmitControl()) id(new AphrontFormSubmitControl())
->setValue($is_serious ? 'Submit' : 'Clowncopterize')); ->setValue($is_serious ? 'Submit' : 'Clowncopterize'));

View file

@ -412,9 +412,10 @@ class ManiphestTaskDetailController extends ManiphestController {
'a', 'a',
array( array(
'href' => $remarkup_href, 'href' => $remarkup_href,
'tabindex' => '-1',
'target' => '_blank', 'target' => '_blank',
), ),
'Remarkup Syntax Reference')) 'Formatting Reference'))
->setID('transaction-comments')) ->setID('transaction-comments'))
->appendChild( ->appendChild(
id(new AphrontFormDragAndDropUploadControl()) id(new AphrontFormDragAndDropUploadControl())

View file

@ -129,6 +129,8 @@ class PhrictionEditController
'a', 'a',
array( array(
'href' => PhabricatorEnv::getDoclink('article/Remarkup_Reference.html'), 'href' => PhabricatorEnv::getDoclink('article/Remarkup_Reference.html'),
'tabindex' => '-1',
'target' => '_blank',
), ),
'Formatting Reference'); 'Formatting Reference');