revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-14 16:51:08 +01:00
Code Issues Releases Wiki Activity

Fix a bad call to "writeInfo()" in "bin/phd stop" with no PHABRICATOR_INSTANCE defined

Browse source 
Summary: See <https://discourse.phabricator-community.org/t/phd-status-calls-to-undefined-method-when-theres-no-instance/2918>. This call should be `logInfo()`.

Test Plan:
  - Purged `PHABRICATOR_INSTANCE` from my environment. In a Phacility development environment, it comes from loading `services/`.
  - Ran `bin/phd stop` with all daemons already stopped.
    - Before: bad call.
    - After: helpful error.
  - Ran some other `bin/phd start`, `bin/phd status`, etc., to kick the tires.
  - Grepped for remaining `writeInfo()` calls (found none).

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20649
This commit is contained in:
epriestley 2019-07-12 08:39:35 -07:00
parent 41ea204144
commit d2935fd7bd
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php
View file

@ -22,7 +22,7 @@ final class PhabricatorDaemonManagementStatusWorkflow
'instance ("%s").', 'instance ("%s").',
$instance)); $instance));
} else { } else {
$this->writeInfo( $this->logInfo(
pht('NO DAEMONS'), pht('NO DAEMONS'),
pht('There are no running daemon processes.')); pht('There are no running daemon processes.'));
} }