revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
Code Issues Releases Wiki Activity

Maniphest Detail view for mobile.

Browse source 
Summary: I try to access tasks a lot on my phone, but its hard to parse. I'm sure most of this will get tossed with new transactions, but wanted to land it anyways.

Test Plan: Test ticket details on iOS simulator and Chrome.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4619
This commit is contained in:
Chad Little 2013-01-24 16:29:47 -08:00
parent 576dcc65b3
commit d3323d0b3d
5 changed files with 64 additions and 57 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

98
src/__celerity_resource_map__.php
View file

@ -663,7 +663,7 @@ celerity_register_resource_map(array(
), ),
'aphront-panel-view-css' => 'aphront-panel-view-css' =>
array( array(
'uri' => '/res/e4ad41d7/rsrc/css/aphront/panel-view.css', 'uri' => '/res/789ff5e5/rsrc/css/aphront/panel-view.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -2337,7 +2337,7 @@ celerity_register_resource_map(array(
), ),
'maniphest-transaction-detail-css' => 'maniphest-transaction-detail-css' =>
array( array(
'uri' => '/res/24e5862f/rsrc/css/application/maniphest/transaction-detail.css', 'uri' => '/res/fb430d3e/rsrc/css/application/maniphest/transaction-detail.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -2895,7 +2895,7 @@ celerity_register_resource_map(array(
), ),
'phabricator-transaction-view-css' => 'phabricator-transaction-view-css' =>
array( array(
'uri' => '/res/731959fb/rsrc/css/aphront/transaction.css', 'uri' => '/res/d3599152/rsrc/css/aphront/transaction.css',
'type' => 'css', 'type' => 'css',
'requires' => 'requires' =>
array( array(
@ -3254,7 +3254,7 @@ celerity_register_resource_map(array(
), array( ), array(
'packages' => 'packages' =>
array( array(
'4dff6da8' => 'd770a9ec' =>
array( array(
'name' => 'core.pkg.css', 'name' => 'core.pkg.css',
'symbols' => 'symbols' =>
@ -3298,7 +3298,7 @@ celerity_register_resource_map(array(
36 => 'phabricator-object-item-list-view-css', 36 => 'phabricator-object-item-list-view-css',
37 => 'global-drag-and-drop-css', 37 => 'global-drag-and-drop-css',
), ),
'uri' => '/res/pkg/4dff6da8/core.pkg.css', 'uri' => '/res/pkg/d770a9ec/core.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'66dca903' => '66dca903' =>
@ -3457,7 +3457,7 @@ celerity_register_resource_map(array(
'uri' => '/res/pkg/fbeded59/javelin.pkg.js', 'uri' => '/res/pkg/fbeded59/javelin.pkg.js',
'type' => 'js', 'type' => 'js',
), ),
'fcdf4c24' => 'e30a3fa8' =>
array( array(
'name' => 'maniphest.pkg.css', 'name' => 'maniphest.pkg.css',
'symbols' => 'symbols' =>
@ -3467,7 +3467,7 @@ celerity_register_resource_map(array(
2 => 'aphront-attached-file-view-css', 2 => 'aphront-attached-file-view-css',
3 => 'phabricator-project-tag-css', 3 => 'phabricator-project-tag-css',
), ),
'uri' => '/res/pkg/fcdf4c24/maniphest.pkg.css', 'uri' => '/res/pkg/e30a3fa8/maniphest.pkg.css',
'type' => 'css', 'type' => 'css',
), ),
'7707de41' => '7707de41' =>
@ -3487,20 +3487,20 @@ celerity_register_resource_map(array(
), ),
'reverse' => 'reverse' =>
array( array(
'aphront-attached-file-view-css' => 'fcdf4c24', 'aphront-attached-file-view-css' => 'e30a3fa8',
'aphront-crumbs-view-css' => '4dff6da8', 'aphront-crumbs-view-css' => 'd770a9ec',
'aphront-dialog-view-css' => '4dff6da8', 'aphront-dialog-view-css' => 'd770a9ec',
'aphront-error-view-css' => '4dff6da8', 'aphront-error-view-css' => 'd770a9ec',
'aphront-form-view-css' => '4dff6da8', 'aphront-form-view-css' => 'd770a9ec',
'aphront-headsup-action-list-view-css' => 'ec01d039', 'aphront-headsup-action-list-view-css' => 'ec01d039',
'aphront-headsup-view-css' => '4dff6da8', 'aphront-headsup-view-css' => 'd770a9ec',
'aphront-list-filter-view-css' => '4dff6da8', 'aphront-list-filter-view-css' => 'd770a9ec',
'aphront-pager-view-css' => '4dff6da8', 'aphront-pager-view-css' => 'd770a9ec',
'aphront-panel-view-css' => '4dff6da8', 'aphront-panel-view-css' => 'd770a9ec',
'aphront-table-view-css' => '4dff6da8', 'aphront-table-view-css' => 'd770a9ec',
'aphront-tokenizer-control-css' => '4dff6da8', 'aphront-tokenizer-control-css' => 'd770a9ec',
'aphront-tooltip-css' => '4dff6da8', 'aphront-tooltip-css' => 'd770a9ec',
'aphront-typeahead-control-css' => '4dff6da8', 'aphront-typeahead-control-css' => 'd770a9ec',
'differential-changeset-view-css' => 'ec01d039', 'differential-changeset-view-css' => 'ec01d039',
'differential-core-view-css' => 'ec01d039', 'differential-core-view-css' => 'ec01d039',
'differential-inline-comment-editor' => 'ac53d36a', 'differential-inline-comment-editor' => 'ac53d36a',
@ -3514,7 +3514,7 @@ celerity_register_resource_map(array(
'differential-table-of-contents-css' => 'ec01d039', 'differential-table-of-contents-css' => 'ec01d039',
'diffusion-commit-view-css' => 'c8ce2d88', 'diffusion-commit-view-css' => 'c8ce2d88',
'diffusion-icons-css' => 'c8ce2d88', 'diffusion-icons-css' => 'c8ce2d88',
'global-drag-and-drop-css' => '4dff6da8', 'global-drag-and-drop-css' => 'd770a9ec',
'inline-comment-summary-css' => 'ec01d039', 'inline-comment-summary-css' => 'ec01d039',
'javelin-aphlict' => '66dca903', 'javelin-aphlict' => '66dca903',
'javelin-behavior' => 'fbeded59', 'javelin-behavior' => 'fbeded59',
@ -3584,48 +3584,48 @@ celerity_register_resource_map(array(
'javelin-util' => 'fbeded59', 'javelin-util' => 'fbeded59',
'javelin-vector' => 'fbeded59', 'javelin-vector' => 'fbeded59',
'javelin-workflow' => 'fbeded59', 'javelin-workflow' => 'fbeded59',
'lightbox-attachment-css' => '4dff6da8', 'lightbox-attachment-css' => 'd770a9ec',
'maniphest-task-summary-css' => 'fcdf4c24', 'maniphest-task-summary-css' => 'e30a3fa8',
'maniphest-transaction-detail-css' => 'fcdf4c24', 'maniphest-transaction-detail-css' => 'e30a3fa8',
'phabricator-busy' => '66dca903', 'phabricator-busy' => '66dca903',
'phabricator-content-source-view-css' => 'ec01d039', 'phabricator-content-source-view-css' => 'ec01d039',
'phabricator-core-buttons-css' => '4dff6da8', 'phabricator-core-buttons-css' => 'd770a9ec',
'phabricator-core-css' => '4dff6da8', 'phabricator-core-css' => 'd770a9ec',
'phabricator-crumbs-view-css' => '4dff6da8', 'phabricator-crumbs-view-css' => 'd770a9ec',
'phabricator-directory-css' => '4dff6da8', 'phabricator-directory-css' => 'd770a9ec',
'phabricator-drag-and-drop-file-upload' => 'ac53d36a', 'phabricator-drag-and-drop-file-upload' => 'ac53d36a',
'phabricator-dropdown-menu' => '66dca903', 'phabricator-dropdown-menu' => '66dca903',
'phabricator-file-upload' => '66dca903', 'phabricator-file-upload' => '66dca903',
'phabricator-filetree-view-css' => '4dff6da8', 'phabricator-filetree-view-css' => 'd770a9ec',
'phabricator-flag-css' => '4dff6da8', 'phabricator-flag-css' => 'd770a9ec',
'phabricator-form-view-css' => '4dff6da8', 'phabricator-form-view-css' => 'd770a9ec',
'phabricator-header-view-css' => '4dff6da8', 'phabricator-header-view-css' => 'd770a9ec',
'phabricator-jump-nav' => '4dff6da8', 'phabricator-jump-nav' => 'd770a9ec',
'phabricator-keyboard-shortcut' => '66dca903', 'phabricator-keyboard-shortcut' => '66dca903',
'phabricator-keyboard-shortcut-manager' => '66dca903', 'phabricator-keyboard-shortcut-manager' => '66dca903',
'phabricator-main-menu-view' => '4dff6da8', 'phabricator-main-menu-view' => 'd770a9ec',
'phabricator-menu-item' => '66dca903', 'phabricator-menu-item' => '66dca903',
'phabricator-nav-view-css' => '4dff6da8', 'phabricator-nav-view-css' => 'd770a9ec',
'phabricator-notification' => '66dca903', 'phabricator-notification' => '66dca903',
'phabricator-notification-css' => '4dff6da8', 'phabricator-notification-css' => 'd770a9ec',
'phabricator-notification-menu-css' => '4dff6da8', 'phabricator-notification-menu-css' => 'd770a9ec',
'phabricator-object-item-list-view-css' => '4dff6da8', 'phabricator-object-item-list-view-css' => 'd770a9ec',
'phabricator-object-selector-css' => 'ec01d039', 'phabricator-object-selector-css' => 'ec01d039',
'phabricator-paste-file-upload' => '66dca903', 'phabricator-paste-file-upload' => '66dca903',
'phabricator-prefab' => '66dca903', 'phabricator-prefab' => '66dca903',
'phabricator-project-tag-css' => 'fcdf4c24', 'phabricator-project-tag-css' => 'e30a3fa8',
'phabricator-remarkup-css' => '4dff6da8', 'phabricator-remarkup-css' => 'd770a9ec',
'phabricator-shaped-request' => 'ac53d36a', 'phabricator-shaped-request' => 'ac53d36a',
'phabricator-side-menu-view-css' => '4dff6da8', 'phabricator-side-menu-view-css' => 'd770a9ec',
'phabricator-standard-page-view' => '4dff6da8', 'phabricator-standard-page-view' => 'd770a9ec',
'phabricator-textareautils' => '66dca903', 'phabricator-textareautils' => '66dca903',
'phabricator-tooltip' => '66dca903', 'phabricator-tooltip' => '66dca903',
'phabricator-transaction-view-css' => '4dff6da8', 'phabricator-transaction-view-css' => 'd770a9ec',
'phabricator-zindex-css' => '4dff6da8', 'phabricator-zindex-css' => 'd770a9ec',
'sprite-apps-large-css' => '4dff6da8', 'sprite-apps-large-css' => 'd770a9ec',
'sprite-gradient-css' => '4dff6da8', 'sprite-gradient-css' => 'd770a9ec',
'sprite-icon-css' => '4dff6da8', 'sprite-icon-css' => 'd770a9ec',
'sprite-menu-css' => '4dff6da8', 'sprite-menu-css' => 'd770a9ec',
'syntax-highlighting-css' => '4dff6da8', 'syntax-highlighting-css' => 'd770a9ec',
), ),
)); ));

12
src/applications/maniphest/controller/ManiphestTaskDetailController.php
View file

@ -302,16 +302,14 @@ final class ManiphestTaskDetailController extends ManiphestController {
'tokenizers' => $tokenizer_map, 'tokenizers' => $tokenizer_map,
)); ));
$comment_panel = new AphrontPanelView(); $comment_header = id(new PhabricatorHeaderView())
$comment_panel->appendChild($comment_form); ->setHeader($is_serious ? pht('Add Comment') : pht('Weigh In'));
$comment_panel->addClass('aphront-panel-accent');
$comment_panel->setHeader($is_serious ? 'Add Comment' : 'Weigh In');
$preview_panel = $preview_panel =
'<div class="aphront-panel-preview"> '<div class="aphront-panel-preview">
<div id="transaction-preview"> <div id="transaction-preview">
<div class="aphront-panel-preview-loading-text"> <div class="aphront-panel-preview-loading-text">
Loading preview... '.pht('Loading preview...').'
</div> </div>
</div> </div>
</div>'; </div>';
@ -346,12 +344,14 @@ final class ManiphestTaskDetailController extends ManiphestController {
$actions, $actions,
$properties, $properties,
$transaction_view, $transaction_view,
$comment_panel, $comment_header,
$comment_form,
$preview_panel, $preview_panel,
), ),
array( array(
'title' => 'T'.$task->getID().' '.$task->getTitle(), 'title' => 'T'.$task->getID().' '.$task->getTitle(),
'pageObjects' => array($task->getPHID()), 'pageObjects' => array($task->getPHID()),
'device' => true,
)); ));
} }

1
webroot/rsrc/css/aphront/panel-view.css
View file

@ -83,7 +83,6 @@
.aphront-panel-preview { .aphront-panel-preview {
background: #fbfbfb; background: #fbfbfb;
border-bottom: 1px solid #aaaaaa; border-bottom: 1px solid #aaaaaa;
margin: -1em 2em 2em;
padding: 15px 20px; padding: 15px 20px;
} }

4
webroot/rsrc/css/aphront/transaction.css
View file

@ -16,6 +16,10 @@
margin-left: 54px; margin-left: 54px;
} }
.device-phone .phabricator-transaction-detail {
margin: 0;
}
.phabricator-transaction-header { .phabricator-transaction-header {
background: #f3f3f3; background: #f3f3f3;
padding: 4px 1em; padding: 4px 1em;

6
webroot/rsrc/css/application/maniphest/transaction-detail.css
View file

@ -3,7 +3,11 @@
*/ */
.maniphest-transaction-list-view { .maniphest-transaction-list-view {
padding: 0 2em; padding: 0 20px;;
}
.device-phone .maniphest-transaction-list-view {
padding: 0 10px;
} }
.maniphest-transaction-list-view .anchor-target { .maniphest-transaction-list-view .anchor-target {