Provide a script to completely destroy revisions

Summary:
Someone may or may not have accidentally uploaded secrets to Differential. Provide an administrative mechanism to permanently destroy a revision.

Also fix some of the transaction handling code.

Test Plan:
  $ ./scripts/differential/destroy_revision.php --trace D1
  >>> [0] <connect>
  <<< [0] <connect> 1,060 us
  >>> [1] <query> SELECT * FROM `differential_revision` WHERE `id` = 1
  <<< [1] <query> 473 us

      Really destroy 'D1: asdbas' forever? [y/N] y

  >>> [2] <connect>
  <<< [2] <connect> 628 us
  >>> [3] <query> START TRANSACTION
  <<< [3] <query> 190 us
  >>> [4] <query> SELECT * FROM `differential_diff` WHERE revisionID = 1
  <<< [4] <query> 510 us
  >>> [5] <query> SAVEPOINT Aphront_Savepoint_1
  <<< [5] <query> 122 us
  >>> [6] <query> SELECT * FROM `differential_changeset` WHERE diffID = 1
  <<< [6] <query> 307 us
  >>> [7] <query> SAVEPOINT Aphront_Savepoint_2
  <<< [7] <query> 241 us
  >>> [8] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 1
  <<< [8] <query> 212 us
  >>> [9] <query> DELETE FROM `differential_hunk` WHERE `id` = 1
  <<< [9] <query> 216 us
  >>> [10] <query> DELETE FROM `differential_changeset` WHERE `id` = 1
  <<< [10] <query> 154 us
  >>> [11] <query> SAVEPOINT Aphront_Savepoint_2
  <<< [11] <query> 118 us
  >>> [12] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 2
  <<< [12] <query> 194 us
  >>> [13] <query> DELETE FROM `differential_hunk` WHERE `id` = 2
  <<< [13] <query> 179 us
  >>> [14] <query> DELETE FROM `differential_changeset` WHERE `id` = 2
  <<< [14] <query> 163 us
  >>> [15] <query> SAVEPOINT Aphront_Savepoint_2
  <<< [15] <query> 105 us
  >>> [16] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 3
  <<< [16] <query> 211 us
  >>> [17] <query> DELETE FROM `differential_hunk` WHERE `id` = 3
  <<< [17] <query> 159 us
  >>> [18] <query> DELETE FROM `differential_changeset` WHERE `id` = 3
  <<< [18] <query> 152 us
  >>> [19] <query> SAVEPOINT Aphront_Savepoint_2
  <<< [19] <query> 124 us
  >>> [20] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 4
  <<< [20] <query> 191 us
  >>> [21] <query> DELETE FROM `differential_hunk` WHERE `id` = 4
  <<< [21] <query> 155 us
  >>> [22] <query> DELETE FROM `differential_changeset` WHERE `id` = 4
  <<< [22] <query> 149 us
  >>> [23] <query> SELECT * FROM `differential_diffproperty` WHERE diffID = 1
  <<< [23] <query> 242 us
  >>> [24] <query> DELETE FROM `differential_diffproperty` WHERE `id` = 1
  <<< [24] <query> 196 us
  >>> [25] <query> DELETE FROM `differential_diff` WHERE `id` = 1
  <<< [25] <query> 169 us
  >>> [26] <query> DELETE FROM `differential_relationship` WHERE revisionID = 1
  <<< [26] <query> 178 us
  >>> [27] <query> DELETE FROM `differential_commit` WHERE revisionID = 1
  <<< [27] <query> 164 us
  >>> [28] <query> SELECT * FROM `differential_comment` WHERE revisionID = 1
  <<< [28] <query> 221 us
  >>> [29] <query> DELETE FROM `differential_comment` WHERE `id` = 1
  <<< [29] <query> 172 us
  >>> [30] <query> SELECT * FROM `differential_inlinecomment` WHERE revisionID = 1
  <<< [30] <query> 296 us
  >>> [31] <query> SELECT * FROM `differential_auxiliaryfield` WHERE revisionPHID = 'PHID-DREV-ooky7ozqukpmwget32oc'
  <<< [31] <query> 308 us
  >>> [32] <query> SELECT * FROM `differential_affectedpath` WHERE revisionID = 1
  <<< [32] <query> 4,173 us
  >>> [33] <query> DELETE FROM `differential_revision` WHERE `id` = 1
  <<< [33] <query> 231 us
  >>> [34] <query> COMMIT
  <<< [34] <query> 686 us
  OK, destroyed revision.

Reviewers: csilvers, vrana, jungejason

Reviewed By: csilvers

CC: aran

Differential Revision: https://secure.phabricator.com/D2796

scripts/differential/destroy_revision.php

@@ -0,0 +1,68 @@
+#!/usr/bin/env php
+<?php
+
+/*
+ * Copyright 2012 Facebook, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+$root = dirname(dirname(dirname(__FILE__)));
+require_once $root.'/scripts/__init_script__.php';
+
+$args = new PhutilArgumentParser($argv);
+$args->setTagline('permanently destroy a Differential Revision');
+$args->setSynopsis(<<<EOHELP
+**destroy_revision.php** __D123__
+  Permanently destroy the specified Differential Revision (for example,
+  because it contains secrets that the world is not ready to know).
+
+  Normally, you can just "Abandon" unwanted revisions, but in dire
+  circumstances this script can be used to completely destroy a
+  revision. Destroying a revision may cause some glitches in
+  linked objects.
+
+  The revision is utterly destroyed and can not be recovered unless you
+  have backups.
+EOHELP
+);
+$args->parseStandardArguments();
+$args->parse(
+  array(
+    array(
+      'name'      => 'revision',
+      'wildcard'  => true,
+    ),
+  ));
+
+$revisions = $args->getArg('revision');
+if (count($revisions) != 1) {
+  $args->printHelpAndExit();
+}
+
+$id = trim(strtolower(head($revisions)), 'd ');
+$revision = id(new DifferentialRevision())->load($id);
+
+if (!$id) {
+  throw new Exception("No revision '{$id}' exists!");
+}
+
+$title = $revision->getTitle();
+$ok = phutil_console_confirm("Really destroy 'D{$id}: {$title}' forever?");
+if (!$ok) {
+  throw new Exception("User aborted workflow.");
+}
+
+$revision->delete();
+echo "OK, destroyed revision.\n";
+

src/applications/differential/storage/DifferentialChangeset.php

@@ -89,25 +89,24 @@ final class DifferentialChangeset extends DifferentialDAO {
   }
 
   public function save() {
-// TODO: Sort out transactions
-//    $this->openTransaction();
+    $this->openTransaction();
       $ret = parent::save();
       foreach ($this->unsavedHunks as $hunk) {
         $hunk->setChangesetID($this->getID());
         $hunk->save();
       }
-//    $this->saveTransaction();
+    $this->saveTransaction();
     return $ret;
   }
 
   public function delete() {
-//    $this->openTransaction();
+    $this->openTransaction();
       foreach ($this->loadHunks() as $hunk) {
         $hunk->delete();
       }
       $this->_hunks = array();
     $ret = parent::delete();
-//    $this->saveTransaction();
+    $this->saveTransaction();
     return $ret;
   }
 

src/applications/differential/storage/DifferentialDiff.php

@@ -98,24 +98,31 @@ final class DifferentialDiff extends DifferentialDAO {
   }
 
   public function save() {
-// TODO: sort out transactions
-//    $this->openTransaction();
+    $this->openTransaction();
       $ret = parent::save();
       foreach ($this->unsavedChangesets as $changeset) {
         $changeset->setDiffID($this->getID());
         $changeset->save();
       }
-//    $this->saveTransaction();
+    $this->saveTransaction();
     return $ret;
   }
 
   public function delete() {
-//    $this->openTransaction();
+    $this->openTransaction();
       foreach ($this->loadChangesets() as $changeset) {
         $changeset->delete();
       }
+
+      $properties = id(new DifferentialDiffProperty())->loadAllWhere(
+        'diffID = %d',
+        $this->getID());
+      foreach ($properties as $prop) {
+        $prop->delete();
+      }
+
       $ret = parent::delete();
-//    $this->saveTransaction();
+    $this->saveTransaction();
     return $ret;
   }
 

src/applications/differential/storage/DifferentialRevision.php

@@ -171,6 +171,60 @@ final class DifferentialRevision extends DifferentialDAO {
     return parent::save();
   }
 
+  public function delete() {
+    $this->openTransaction();
+      $diffs = $this->loadDiffs();
+      foreach ($diffs as $diff) {
+        $diff->delete();
+      }
+
+      $conn_w = $this->establishConnection('w');
+
+      queryfx(
+        $conn_w,
+        'DELETE FROM %T WHERE revisionID = %d',
+        self::RELATIONSHIP_TABLE,
+        $this->getID());
+
+      queryfx(
+        $conn_w,
+        'DELETE FROM %T WHERE revisionID = %d',
+        self::TABLE_COMMIT,
+        $this->getID());
+
+      $comments = id(new DifferentialComment())->loadAllWhere(
+        'revisionID = %d',
+        $this->getID());
+      foreach ($comments as $comment) {
+        $comment->delete();
+      }
+
+      $inlines = id(new DifferentialInlineComment())->loadAllWhere(
+        'revisionID = %d',
+        $this->getID());
+      foreach ($inlines as $inline) {
+        $inline->delete();
+      }
+
+      $fields = id(new DifferentialAuxiliaryField())->loadAllWhere(
+        'revisionPHID = %s',
+        $this->getPHID());
+      foreach ($fields as $field) {
+        $field->delete();
+      }
+
+      $paths = id(new DifferentialAffectedPath())->loadAllWhere(
+        'revisionID = %d',
+        $this->getID());
+      foreach ($paths as $path) {
+        $path->delete();
+      }
+
+      $result = parent::delete();
+    $this->saveTransaction();
+    return $result;
+  }
+
   public function loadRelationships() {
     if (!$this->getID()) {
       $this->relationships = array();