mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 02:02:41 +01:00
d4b6b095cb
Summary: Someone may or may not have accidentally uploaded secrets to Differential. Provide an administrative mechanism to permanently destroy a revision. Also fix some of the transaction handling code. Test Plan: $ ./scripts/differential/destroy_revision.php --trace D1 >>> [0] <connect> <<< [0] <connect> 1,060 us >>> [1] <query> SELECT * FROM `differential_revision` WHERE `id` = 1 <<< [1] <query> 473 us Really destroy 'D1: asdbas' forever? [y/N] y >>> [2] <connect> <<< [2] <connect> 628 us >>> [3] <query> START TRANSACTION <<< [3] <query> 190 us >>> [4] <query> SELECT * FROM `differential_diff` WHERE revisionID = 1 <<< [4] <query> 510 us >>> [5] <query> SAVEPOINT Aphront_Savepoint_1 <<< [5] <query> 122 us >>> [6] <query> SELECT * FROM `differential_changeset` WHERE diffID = 1 <<< [6] <query> 307 us >>> [7] <query> SAVEPOINT Aphront_Savepoint_2 <<< [7] <query> 241 us >>> [8] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 1 <<< [8] <query> 212 us >>> [9] <query> DELETE FROM `differential_hunk` WHERE `id` = 1 <<< [9] <query> 216 us >>> [10] <query> DELETE FROM `differential_changeset` WHERE `id` = 1 <<< [10] <query> 154 us >>> [11] <query> SAVEPOINT Aphront_Savepoint_2 <<< [11] <query> 118 us >>> [12] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 2 <<< [12] <query> 194 us >>> [13] <query> DELETE FROM `differential_hunk` WHERE `id` = 2 <<< [13] <query> 179 us >>> [14] <query> DELETE FROM `differential_changeset` WHERE `id` = 2 <<< [14] <query> 163 us >>> [15] <query> SAVEPOINT Aphront_Savepoint_2 <<< [15] <query> 105 us >>> [16] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 3 <<< [16] <query> 211 us >>> [17] <query> DELETE FROM `differential_hunk` WHERE `id` = 3 <<< [17] <query> 159 us >>> [18] <query> DELETE FROM `differential_changeset` WHERE `id` = 3 <<< [18] <query> 152 us >>> [19] <query> SAVEPOINT Aphront_Savepoint_2 <<< [19] <query> 124 us >>> [20] <query> SELECT * FROM `differential_hunk` WHERE changesetID = 4 <<< [20] <query> 191 us >>> [21] <query> DELETE FROM `differential_hunk` WHERE `id` = 4 <<< [21] <query> 155 us >>> [22] <query> DELETE FROM `differential_changeset` WHERE `id` = 4 <<< [22] <query> 149 us >>> [23] <query> SELECT * FROM `differential_diffproperty` WHERE diffID = 1 <<< [23] <query> 242 us >>> [24] <query> DELETE FROM `differential_diffproperty` WHERE `id` = 1 <<< [24] <query> 196 us >>> [25] <query> DELETE FROM `differential_diff` WHERE `id` = 1 <<< [25] <query> 169 us >>> [26] <query> DELETE FROM `differential_relationship` WHERE revisionID = 1 <<< [26] <query> 178 us >>> [27] <query> DELETE FROM `differential_commit` WHERE revisionID = 1 <<< [27] <query> 164 us >>> [28] <query> SELECT * FROM `differential_comment` WHERE revisionID = 1 <<< [28] <query> 221 us >>> [29] <query> DELETE FROM `differential_comment` WHERE `id` = 1 <<< [29] <query> 172 us >>> [30] <query> SELECT * FROM `differential_inlinecomment` WHERE revisionID = 1 <<< [30] <query> 296 us >>> [31] <query> SELECT * FROM `differential_auxiliaryfield` WHERE revisionPHID = 'PHID-DREV-ooky7ozqukpmwget32oc' <<< [31] <query> 308 us >>> [32] <query> SELECT * FROM `differential_affectedpath` WHERE revisionID = 1 <<< [32] <query> 4,173 us >>> [33] <query> DELETE FROM `differential_revision` WHERE `id` = 1 <<< [33] <query> 231 us >>> [34] <query> COMMIT <<< [34] <query> 686 us OK, destroyed revision. Reviewers: csilvers, vrana, jungejason Reviewed By: csilvers CC: aran Differential Revision: https://secure.phabricator.com/D2796
299 lines
7.6 KiB
PHP
299 lines
7.6 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2012 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
final class DifferentialRevision extends DifferentialDAO {
|
|
|
|
protected $title;
|
|
protected $originalTitle;
|
|
protected $status;
|
|
|
|
protected $summary;
|
|
protected $testPlan;
|
|
|
|
protected $phid;
|
|
protected $authorPHID;
|
|
protected $lastReviewerPHID;
|
|
|
|
protected $dateCommitted;
|
|
|
|
protected $lineCount;
|
|
protected $attached = array();
|
|
protected $unsubscribed = array();
|
|
|
|
protected $mailKey;
|
|
protected $branchName;
|
|
protected $arcanistProjectPHID;
|
|
|
|
private $relationships;
|
|
private $commits;
|
|
private $activeDiff = false;
|
|
private $diffIDs;
|
|
|
|
|
|
const RELATIONSHIP_TABLE = 'differential_relationship';
|
|
const TABLE_COMMIT = 'differential_commit';
|
|
|
|
const RELATION_REVIEWER = 'revw';
|
|
const RELATION_SUBSCRIBED = 'subd';
|
|
|
|
public function getConfiguration() {
|
|
return array(
|
|
self::CONFIG_AUX_PHID => true,
|
|
self::CONFIG_SERIALIZATION => array(
|
|
'attached' => self::SERIALIZATION_JSON,
|
|
'unsubscribed' => self::SERIALIZATION_JSON,
|
|
),
|
|
) + parent::getConfiguration();
|
|
}
|
|
|
|
public function setTitle($title) {
|
|
$this->title = $title;
|
|
if (!$this->getID()) {
|
|
$this->originalTitle = $title;
|
|
}
|
|
return $this;
|
|
}
|
|
|
|
public function loadCommitPHIDs() {
|
|
if (!$this->getID()) {
|
|
return ($this->commits = array());
|
|
}
|
|
|
|
$commits = queryfx_all(
|
|
$this->establishConnection('r'),
|
|
'SELECT commitPHID FROM %T WHERE revisionID = %d',
|
|
self::TABLE_COMMIT,
|
|
$this->getID());
|
|
$commits = ipull($commits, 'commitPHID');
|
|
|
|
return ($this->commits = $commits);
|
|
}
|
|
|
|
public function getCommitPHIDs() {
|
|
if ($this->commits === null) {
|
|
throw new Exception("Must attach commits first!");
|
|
}
|
|
return $this->commits;
|
|
}
|
|
|
|
public function getActiveDiff() {
|
|
// TODO: Because it's currently technically possible to create a revision
|
|
// without an associated diff, we allow an attached-but-null active diff.
|
|
// It would be good to get rid of this once we make diff-attaching
|
|
// transactional.
|
|
|
|
if ($this->activeDiff === false) {
|
|
throw new Exception("Must attach active diff first!");
|
|
}
|
|
return $this->activeDiff;
|
|
}
|
|
|
|
public function attachActiveDiff($diff) {
|
|
$this->activeDiff = $diff;
|
|
return $this;
|
|
}
|
|
|
|
public function getDiffIDs() {
|
|
if ($this->diffIDs === null) {
|
|
throw new Exception("Must attach diff IDs first!");
|
|
}
|
|
return $this->diffIDs;
|
|
}
|
|
|
|
public function attachDiffIDs(array $ids) {
|
|
rsort($ids);
|
|
$this->diffIDs = array_values($ids);
|
|
return $this;
|
|
}
|
|
|
|
public function attachCommitPHIDs(array $phids) {
|
|
$this->commits = array_values($phids);
|
|
return $this;
|
|
}
|
|
|
|
public function getAttachedPHIDs($type) {
|
|
return array_keys(idx($this->attached, $type, array()));
|
|
}
|
|
|
|
public function setAttachedPHIDs($type, array $phids) {
|
|
$this->attached[$type] = array_fill_keys($phids, array());
|
|
return $this;
|
|
}
|
|
|
|
public function generatePHID() {
|
|
return PhabricatorPHID::generateNewPHID(
|
|
PhabricatorPHIDConstants::PHID_TYPE_DREV);
|
|
}
|
|
|
|
public function loadDiffs() {
|
|
if (!$this->getID()) {
|
|
return array();
|
|
}
|
|
return id(new DifferentialDiff())->loadAllWhere(
|
|
'revisionID = %d',
|
|
$this->getID());
|
|
}
|
|
|
|
public function loadComments() {
|
|
if (!$this->getID()) {
|
|
return array();
|
|
}
|
|
return id(new DifferentialComment())->loadAllWhere(
|
|
'revisionID = %d',
|
|
$this->getID());
|
|
}
|
|
|
|
public function loadActiveDiff() {
|
|
return id(new DifferentialDiff())->loadOneWhere(
|
|
'revisionID = %d ORDER BY id DESC LIMIT 1',
|
|
$this->getID());
|
|
}
|
|
|
|
public function save() {
|
|
if (!$this->getMailKey()) {
|
|
$this->mailKey = Filesystem::readRandomCharacters(40);
|
|
}
|
|
return parent::save();
|
|
}
|
|
|
|
public function delete() {
|
|
$this->openTransaction();
|
|
$diffs = $this->loadDiffs();
|
|
foreach ($diffs as $diff) {
|
|
$diff->delete();
|
|
}
|
|
|
|
$conn_w = $this->establishConnection('w');
|
|
|
|
queryfx(
|
|
$conn_w,
|
|
'DELETE FROM %T WHERE revisionID = %d',
|
|
self::RELATIONSHIP_TABLE,
|
|
$this->getID());
|
|
|
|
queryfx(
|
|
$conn_w,
|
|
'DELETE FROM %T WHERE revisionID = %d',
|
|
self::TABLE_COMMIT,
|
|
$this->getID());
|
|
|
|
$comments = id(new DifferentialComment())->loadAllWhere(
|
|
'revisionID = %d',
|
|
$this->getID());
|
|
foreach ($comments as $comment) {
|
|
$comment->delete();
|
|
}
|
|
|
|
$inlines = id(new DifferentialInlineComment())->loadAllWhere(
|
|
'revisionID = %d',
|
|
$this->getID());
|
|
foreach ($inlines as $inline) {
|
|
$inline->delete();
|
|
}
|
|
|
|
$fields = id(new DifferentialAuxiliaryField())->loadAllWhere(
|
|
'revisionPHID = %s',
|
|
$this->getPHID());
|
|
foreach ($fields as $field) {
|
|
$field->delete();
|
|
}
|
|
|
|
$paths = id(new DifferentialAffectedPath())->loadAllWhere(
|
|
'revisionID = %d',
|
|
$this->getID());
|
|
foreach ($paths as $path) {
|
|
$path->delete();
|
|
}
|
|
|
|
$result = parent::delete();
|
|
$this->saveTransaction();
|
|
return $result;
|
|
}
|
|
|
|
public function loadRelationships() {
|
|
if (!$this->getID()) {
|
|
$this->relationships = array();
|
|
return;
|
|
}
|
|
|
|
$data = queryfx_all(
|
|
$this->establishConnection('r'),
|
|
'SELECT * FROM %T WHERE revisionID = %d ORDER BY sequence',
|
|
self::RELATIONSHIP_TABLE,
|
|
$this->getID());
|
|
|
|
return $this->attachRelationships($data);
|
|
}
|
|
|
|
public function attachRelationships(array $relationships) {
|
|
$this->relationships = igroup($relationships, 'relation');
|
|
return $this;
|
|
}
|
|
|
|
public function getReviewers() {
|
|
return $this->getRelatedPHIDs(self::RELATION_REVIEWER);
|
|
}
|
|
|
|
public function getCCPHIDs() {
|
|
return $this->getRelatedPHIDs(self::RELATION_SUBSCRIBED);
|
|
}
|
|
|
|
private function getRelatedPHIDs($relation) {
|
|
if ($this->relationships === null) {
|
|
throw new Exception("Must load relationships!");
|
|
}
|
|
|
|
return ipull($this->getRawRelations($relation), 'objectPHID');
|
|
}
|
|
|
|
public function getRawRelations($relation) {
|
|
return idx($this->relationships, $relation, array());
|
|
}
|
|
|
|
public function getUnsubscribedPHIDs() {
|
|
return array_keys($this->getUnsubscribed());
|
|
}
|
|
|
|
public function getPrimaryReviewer() {
|
|
if (!$this->lastReviewerPHID) {
|
|
return head($this->getReviewers());
|
|
}
|
|
return $this->lastReviewerPHID;
|
|
}
|
|
|
|
public function loadReviewedBy() {
|
|
$reviewer = null;
|
|
|
|
if ($this->status == ArcanistDifferentialRevisionStatus::ACCEPTED ||
|
|
$this->status == ArcanistDifferentialRevisionStatus::CLOSED) {
|
|
$comments = $this->loadComments();
|
|
foreach ($comments as $comment) {
|
|
$action = $comment->getAction();
|
|
if ($action == DifferentialAction::ACTION_ACCEPT) {
|
|
$reviewer = $comment->getAuthorPHID();
|
|
} else if ($action == DifferentialAction::ACTION_REJECT ||
|
|
$action == DifferentialAction::ACTION_ABANDON ||
|
|
$action == DifferentialAction::ACTION_RETHINK) {
|
|
$reviewer = null;
|
|
}
|
|
}
|
|
}
|
|
|
|
return $reviewer;
|
|
}
|
|
}
|